From f00c9faf03f6c12e5bf6ee48789c54f8746470bb Mon Sep 17 00:00:00 2001 From: leevardaro Date: Tue, 25 Jan 2022 13:59:12 -0500 Subject: [PATCH 01/23] added creds --- src/test/resources/conf/local.conf.json | 4 ++-- src/test/resources/conf/parallel.conf.json | 4 ++-- src/test/resources/conf/single.conf.json | 4 ++-- src/test/resources/conf/suite.conf.json | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/test/resources/conf/local.conf.json b/src/test/resources/conf/local.conf.json index 27416af..0b0f2e5 100644 --- a/src/test/resources/conf/local.conf.json +++ b/src/test/resources/conf/local.conf.json @@ -1,7 +1,7 @@ { "server": "hub-cloud.browserstack.com", - "user": "BROWSERSTACK_USERNAME", - "key": "BROWSERSTACK_ACCESS_KEY", + "user": "leevdemo_v6C3E4", + "key": "SqphqTHCspKmzT3z3eka", "capabilities": { "build": "browserstack-build-1", diff --git a/src/test/resources/conf/parallel.conf.json b/src/test/resources/conf/parallel.conf.json index 48bc9c7..9b9eeb4 100644 --- a/src/test/resources/conf/parallel.conf.json +++ b/src/test/resources/conf/parallel.conf.json @@ -1,7 +1,7 @@ { "server": "hub-cloud.browserstack.com", - "user": "BROWSERSTACK_USERNAME", - "key": "BROWSERSTACK_ACCESS_KEY", + "user": "leevdemo_v6C3E4", + "key": "SqphqTHCspKmzT3z3eka", "capabilities": { "build": "browserstack-build-1", diff --git a/src/test/resources/conf/single.conf.json b/src/test/resources/conf/single.conf.json index 3de3fd5..9fb0ff4 100644 --- a/src/test/resources/conf/single.conf.json +++ b/src/test/resources/conf/single.conf.json @@ -1,7 +1,7 @@ { "server": "hub-cloud.browserstack.com", - "user": "BROWSERSTACK_USERNAME", - "key": "BROWSERSTACK_ACCESS_KEY", + "user": "leevdemo_v6C3E4", + "key": "SqphqTHCspKmzT3z3eka", "capabilities": { "build": "browserstack-build-1", diff --git a/src/test/resources/conf/suite.conf.json b/src/test/resources/conf/suite.conf.json index 7f19ce1..d3b44f7 100644 --- a/src/test/resources/conf/suite.conf.json +++ b/src/test/resources/conf/suite.conf.json @@ -1,7 +1,7 @@ { "server": "hub-cloud.browserstack.com", - "user": "BROWSERSTACK_USERNAME", - "key": "BROWSERSTACK_ACCESS_KEY", + "user": "leevdemo_v6C3E4", + "key": "SqphqTHCspKmzT3z3eka", "capabilities": { "build": "browserstack-build-1", From 204fe3dd60dd2d9c2e391886fb31253c4a590562 Mon Sep 17 00:00:00 2001 From: leevardaro Date: Tue, 25 Jan 2022 14:05:20 -0500 Subject: [PATCH 02/23] added creds --- pom.xml | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/pom.xml b/pom.xml index 96dc165..a91933a 100644 --- a/pom.xml +++ b/pom.xml @@ -50,11 +50,45 @@ + + maven-clean-plugin + 3.1.0 + + + + maven-resources-plugin + 3.0.2 + + + maven-compiler-plugin + 3.8.0 + org.apache.maven.plugins maven-surefire-plugin 2.18.1 + + maven-jar-plugin + 3.0.2 + + + maven-install-plugin + 2.5.2 + + + maven-deploy-plugin + 2.8.2 + + + + maven-site-plugin + 3.7.1 + + + maven-project-info-reports-plugin + 3.0.0 + From b4e87d635bfcad44d442e44dbfd33b68ce6703a3 Mon Sep 17 00:00:00 2001 From: leevardaro Date: Tue, 25 Jan 2022 14:08:46 -0500 Subject: [PATCH 03/23] fixed pom --- pom.xml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/pom.xml b/pom.xml index a91933a..90408ff 100644 --- a/pom.xml +++ b/pom.xml @@ -89,6 +89,15 @@ maven-project-info-reports-plugin 3.0.0 + + + org.apache.maven.plugins + maven-compiler-plugin + + 8 + 8 + + From 8e745ee73fb3a10523676786fd539aa4bec05db8 Mon Sep 17 00:00:00 2001 From: leevardaro Date: Tue, 25 Jan 2022 14:19:08 -0500 Subject: [PATCH 04/23] fixed pom --- pom.xml | 79 +++++++-------------------------------------------------- 1 file changed, 9 insertions(+), 70 deletions(-) diff --git a/pom.xml b/pom.xml index 90408ff..4000603 100644 --- a/pom.xml +++ b/pom.xml @@ -16,7 +16,7 @@ 1.6 2.19.1 - + default default @@ -67,6 +67,14 @@ org.apache.maven.plugins maven-surefire-plugin 2.18.1 + + + config/single.testng.xml + config/local.testng.xml + config/parallel.testng.xml + config/suite.testng.xml + + maven-jar-plugin @@ -101,74 +109,5 @@ - - - single - - - - org.apache.maven.plugins - maven-surefire-plugin - - - config/single.testng.xml - - - - - - - - - local - - - - org.apache.maven.plugins - maven-surefire-plugin - - - config/local.testng.xml - - - - - - - - - parallel - - - - org.apache.maven.plugins - maven-surefire-plugin - - - config/parallel.testng.xml - - - - - - - - - suite - - - - org.apache.maven.plugins - maven-surefire-plugin - - - config/suite.testng.xml - - - - - - - From 33eec947896000b430171002c2fe139f5231ab3e Mon Sep 17 00:00:00 2001 From: leevardaro Date: Tue, 25 Jan 2022 14:22:15 -0500 Subject: [PATCH 05/23] fixed pom --- pom.xml | 44 +------------------------------------------- 1 file changed, 1 insertion(+), 43 deletions(-) diff --git a/pom.xml b/pom.xml index 4000603..cf521f8 100644 --- a/pom.xml +++ b/pom.xml @@ -50,19 +50,7 @@ - - maven-clean-plugin - 3.1.0 - - - - maven-resources-plugin - 3.0.2 - - - maven-compiler-plugin - 3.8.0 - + org.apache.maven.plugins maven-surefire-plugin @@ -76,36 +64,6 @@ - - maven-jar-plugin - 3.0.2 - - - maven-install-plugin - 2.5.2 - - - maven-deploy-plugin - 2.8.2 - - - - maven-site-plugin - 3.7.1 - - - maven-project-info-reports-plugin - 3.0.0 - - - - org.apache.maven.plugins - maven-compiler-plugin - - 8 - 8 - - From 33d28659f56a46733241f7bd25f6affe0cb98b60 Mon Sep 17 00:00:00 2001 From: leevardaro Date: Tue, 25 Jan 2022 14:25:09 -0500 Subject: [PATCH 06/23] fixed pom --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index cf521f8..38212f5 100644 --- a/pom.xml +++ b/pom.xml @@ -16,7 +16,7 @@ 1.6 2.19.1 - default + default From 0f77681db962febfc4c7f86c6c62662f767ae822 Mon Sep 17 00:00:00 2001 From: leevardaro Date: Tue, 25 Jan 2022 14:36:43 -0500 Subject: [PATCH 07/23] fixed pom --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 38212f5..4501683 100644 --- a/pom.xml +++ b/pom.xml @@ -12,8 +12,8 @@ UTF-8 - 1.6 - 1.6 + 1.7 + 1.7 2.19.1 From 36648c1959e628d3ad53cdcac29a3b5eecabb945 Mon Sep 17 00:00:00 2001 From: leevardaro Date: Tue, 25 Jan 2022 14:40:10 -0500 Subject: [PATCH 08/23] increased threads --- config/parallel.testng.xml | 2 +- config/suite.testng.xml | 2 +- pom.xml | 2 ++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/config/parallel.testng.xml b/config/parallel.testng.xml index 24c4721..65ad743 100644 --- a/config/parallel.testng.xml +++ b/config/parallel.testng.xml @@ -1,6 +1,6 @@ - + diff --git a/config/suite.testng.xml b/config/suite.testng.xml index 365fdba..dad377a 100644 --- a/config/suite.testng.xml +++ b/config/suite.testng.xml @@ -1,7 +1,7 @@ - + diff --git a/pom.xml b/pom.xml index 4501683..242100a 100644 --- a/pom.xml +++ b/pom.xml @@ -56,6 +56,8 @@ maven-surefire-plugin 2.18.1 + methods + 20 config/single.testng.xml config/local.testng.xml From 13a5a4efafadb2a36a51fe4c41a012095d11b5f3 Mon Sep 17 00:00:00 2001 From: leevardaro Date: Tue, 25 Jan 2022 15:40:19 -0500 Subject: [PATCH 09/23] increased threads --- pom.xml | 68 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 68 insertions(+) diff --git a/pom.xml b/pom.xml index 242100a..2b81349 100644 --- a/pom.xml +++ b/pom.xml @@ -68,6 +68,74 @@ + + + single + + + + org.apache.maven.plugins + maven-surefire-plugin + + + config/single.testng.xml + + + + + + + + local + + + + org.apache.maven.plugins + maven-surefire-plugin + + + config/local.testng.xml + + + + + + + + + parallel + + + + org.apache.maven.plugins + maven-surefire-plugin + + + config/parallel.testng.xml + + + + + + + + + suite + + + + org.apache.maven.plugins + maven-surefire-plugin + + + config/suite.testng.xml + + + + + + + From b8ed4300e506d59627de09451cc8a394672aa727 Mon Sep 17 00:00:00 2001 From: leevardaro Date: Tue, 25 Jan 2022 15:45:28 -0500 Subject: [PATCH 10/23] added parallel to suites --- pom.xml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/pom.xml b/pom.xml index 2b81349..1b7027c 100644 --- a/pom.xml +++ b/pom.xml @@ -64,6 +64,12 @@ config/parallel.testng.xml config/suite.testng.xml + + + suitethreadpoolsize + 4 + + From 78693218bc65439c329f13f7a3fbc8cdfae7f05a Mon Sep 17 00:00:00 2001 From: leevardaro Date: Tue, 1 Feb 2022 10:24:08 -0500 Subject: [PATCH 11/23] cleaned up pom and configs --- config/parallel.testng.xml | 2 +- config/suite.testng.xml | 2 +- pom.xml | 6 +----- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/config/parallel.testng.xml b/config/parallel.testng.xml index 65ad743..24c4721 100644 --- a/config/parallel.testng.xml +++ b/config/parallel.testng.xml @@ -1,6 +1,6 @@ - + diff --git a/config/suite.testng.xml b/config/suite.testng.xml index dad377a..365fdba 100644 --- a/config/suite.testng.xml +++ b/config/suite.testng.xml @@ -1,7 +1,7 @@ - + diff --git a/pom.xml b/pom.xml index 1b7027c..0f73aeb 100644 --- a/pom.xml +++ b/pom.xml @@ -50,14 +50,13 @@ - org.apache.maven.plugins maven-surefire-plugin 2.18.1 methods - 20 + 5 config/single.testng.xml config/local.testng.xml @@ -91,7 +90,6 @@ - local @@ -108,7 +106,6 @@ - parallel @@ -125,7 +122,6 @@ - suite From 4dc9bad435c1fa0d6e8a6bc6137ef2c138687dc9 Mon Sep 17 00:00:00 2001 From: leevardaro Date: Tue, 1 Feb 2022 10:28:29 -0500 Subject: [PATCH 12/23] added configs to POM for CI/CD and parallel threads --- pom.xml | 4 ++++ src/test/resources/conf/local.conf.json | 4 ++-- src/test/resources/conf/parallel.conf.json | 4 ++-- src/test/resources/conf/single.conf.json | 4 ++-- src/test/resources/conf/suite.conf.json | 4 ++-- 5 files changed, 12 insertions(+), 8 deletions(-) diff --git a/pom.xml b/pom.xml index 0f73aeb..17f91b8 100644 --- a/pom.xml +++ b/pom.xml @@ -73,6 +73,7 @@ + single @@ -90,6 +91,7 @@ + local @@ -106,6 +108,7 @@ + parallel @@ -122,6 +125,7 @@ + suite diff --git a/src/test/resources/conf/local.conf.json b/src/test/resources/conf/local.conf.json index 0b0f2e5..27416af 100644 --- a/src/test/resources/conf/local.conf.json +++ b/src/test/resources/conf/local.conf.json @@ -1,7 +1,7 @@ { "server": "hub-cloud.browserstack.com", - "user": "leevdemo_v6C3E4", - "key": "SqphqTHCspKmzT3z3eka", + "user": "BROWSERSTACK_USERNAME", + "key": "BROWSERSTACK_ACCESS_KEY", "capabilities": { "build": "browserstack-build-1", diff --git a/src/test/resources/conf/parallel.conf.json b/src/test/resources/conf/parallel.conf.json index 9b9eeb4..48bc9c7 100644 --- a/src/test/resources/conf/parallel.conf.json +++ b/src/test/resources/conf/parallel.conf.json @@ -1,7 +1,7 @@ { "server": "hub-cloud.browserstack.com", - "user": "leevdemo_v6C3E4", - "key": "SqphqTHCspKmzT3z3eka", + "user": "BROWSERSTACK_USERNAME", + "key": "BROWSERSTACK_ACCESS_KEY", "capabilities": { "build": "browserstack-build-1", diff --git a/src/test/resources/conf/single.conf.json b/src/test/resources/conf/single.conf.json index 9fb0ff4..3de3fd5 100644 --- a/src/test/resources/conf/single.conf.json +++ b/src/test/resources/conf/single.conf.json @@ -1,7 +1,7 @@ { "server": "hub-cloud.browserstack.com", - "user": "leevdemo_v6C3E4", - "key": "SqphqTHCspKmzT3z3eka", + "user": "BROWSERSTACK_USERNAME", + "key": "BROWSERSTACK_ACCESS_KEY", "capabilities": { "build": "browserstack-build-1", diff --git a/src/test/resources/conf/suite.conf.json b/src/test/resources/conf/suite.conf.json index d3b44f7..7f19ce1 100644 --- a/src/test/resources/conf/suite.conf.json +++ b/src/test/resources/conf/suite.conf.json @@ -1,7 +1,7 @@ { "server": "hub-cloud.browserstack.com", - "user": "leevdemo_v6C3E4", - "key": "SqphqTHCspKmzT3z3eka", + "user": "BROWSERSTACK_USERNAME", + "key": "BROWSERSTACK_ACCESS_KEY", "capabilities": { "build": "browserstack-build-1", From 17366bb27f684fcd9d089150bd7a6d4077603e63 Mon Sep 17 00:00:00 2001 From: leevardaro Date: Tue, 1 Feb 2022 10:36:08 -0500 Subject: [PATCH 13/23] added configs to POM for CI/CD and parallel threads --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 17f91b8..ca0f27d 100644 --- a/pom.xml +++ b/pom.xml @@ -56,7 +56,7 @@ 2.18.1 methods - 5 + 3 config/single.testng.xml config/local.testng.xml From 49f71964f30fdefeeac44a975f3cf1c481b9e684 Mon Sep 17 00:00:00 2001 From: leevardaro Date: Thu, 3 Feb 2022 17:57:38 -0500 Subject: [PATCH 14/23] removing user and key --- src/test/resources/conf/parallel.conf.json | 3 +-- src/test/resources/conf/single.conf.json | 2 -- src/test/resources/conf/suite.conf.json | 3 +-- 3 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/test/resources/conf/parallel.conf.json b/src/test/resources/conf/parallel.conf.json index 48bc9c7..bce2584 100644 --- a/src/test/resources/conf/parallel.conf.json +++ b/src/test/resources/conf/parallel.conf.json @@ -1,7 +1,6 @@ { "server": "hub-cloud.browserstack.com", - "user": "BROWSERSTACK_USERNAME", - "key": "BROWSERSTACK_ACCESS_KEY", + "capabilities": { "build": "browserstack-build-1", diff --git a/src/test/resources/conf/single.conf.json b/src/test/resources/conf/single.conf.json index 3de3fd5..364a2e8 100644 --- a/src/test/resources/conf/single.conf.json +++ b/src/test/resources/conf/single.conf.json @@ -1,7 +1,5 @@ { "server": "hub-cloud.browserstack.com", - "user": "BROWSERSTACK_USERNAME", - "key": "BROWSERSTACK_ACCESS_KEY", "capabilities": { "build": "browserstack-build-1", diff --git a/src/test/resources/conf/suite.conf.json b/src/test/resources/conf/suite.conf.json index 7f19ce1..4962714 100644 --- a/src/test/resources/conf/suite.conf.json +++ b/src/test/resources/conf/suite.conf.json @@ -1,7 +1,6 @@ { "server": "hub-cloud.browserstack.com", - "user": "BROWSERSTACK_USERNAME", - "key": "BROWSERSTACK_ACCESS_KEY", + "capabilities": { "build": "browserstack-build-1", From 90b72f92dd59db110e228fa1ca7933a81feff598 Mon Sep 17 00:00:00 2001 From: leevardaro Date: Thu, 3 Feb 2022 17:59:15 -0500 Subject: [PATCH 15/23] removing user and key --- src/test/resources/conf/parallel.conf.json | 3 ++- src/test/resources/conf/single.conf.json | 2 ++ src/test/resources/conf/suite.conf.json | 3 ++- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/test/resources/conf/parallel.conf.json b/src/test/resources/conf/parallel.conf.json index bce2584..48bc9c7 100644 --- a/src/test/resources/conf/parallel.conf.json +++ b/src/test/resources/conf/parallel.conf.json @@ -1,6 +1,7 @@ { "server": "hub-cloud.browserstack.com", - + "user": "BROWSERSTACK_USERNAME", + "key": "BROWSERSTACK_ACCESS_KEY", "capabilities": { "build": "browserstack-build-1", diff --git a/src/test/resources/conf/single.conf.json b/src/test/resources/conf/single.conf.json index 364a2e8..3de3fd5 100644 --- a/src/test/resources/conf/single.conf.json +++ b/src/test/resources/conf/single.conf.json @@ -1,5 +1,7 @@ { "server": "hub-cloud.browserstack.com", + "user": "BROWSERSTACK_USERNAME", + "key": "BROWSERSTACK_ACCESS_KEY", "capabilities": { "build": "browserstack-build-1", diff --git a/src/test/resources/conf/suite.conf.json b/src/test/resources/conf/suite.conf.json index 4962714..bba5e53 100644 --- a/src/test/resources/conf/suite.conf.json +++ b/src/test/resources/conf/suite.conf.json @@ -1,6 +1,7 @@ { "server": "hub-cloud.browserstack.com", - + "user": null, + "key": null, "capabilities": { "build": "browserstack-build-1", From 122a24c9baa350c8d84e02155ae9386d1d290413 Mon Sep 17 00:00:00 2001 From: leevardaro Date: Thu, 3 Feb 2022 18:07:31 -0500 Subject: [PATCH 16/23] removing user and key --- src/test/java/com/browserstack/BrowserStackTestNGTest.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/test/java/com/browserstack/BrowserStackTestNGTest.java b/src/test/java/com/browserstack/BrowserStackTestNGTest.java index 81682b3..d3d22c8 100644 --- a/src/test/java/com/browserstack/BrowserStackTestNGTest.java +++ b/src/test/java/com/browserstack/BrowserStackTestNGTest.java @@ -63,6 +63,8 @@ public void setUp(String config_file, String environment) throws Exception { options.put("key", accessKey); l.start(options); } + String buildName = System.getenv("BROWSERSTACK_BUILD_NAME"); + capabilities.setCapability("build", buildName); driver = new RemoteWebDriver( new URL("http://" + username + ":" + accessKey + "@" + config.get("server") + "/wd/hub"), capabilities); From dbabe53925676e8fce6ea93ea80279c06e75a10a Mon Sep 17 00:00:00 2001 From: leevardaro Date: Thu, 3 Feb 2022 18:09:48 -0500 Subject: [PATCH 17/23] removing user and key --- config/parallel.testng.xml | 2 +- config/suite.testng.xml | 2 +- pom.xml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/config/parallel.testng.xml b/config/parallel.testng.xml index 24c4721..65ad743 100644 --- a/config/parallel.testng.xml +++ b/config/parallel.testng.xml @@ -1,6 +1,6 @@ - + diff --git a/config/suite.testng.xml b/config/suite.testng.xml index 365fdba..dad377a 100644 --- a/config/suite.testng.xml +++ b/config/suite.testng.xml @@ -1,7 +1,7 @@ - + diff --git a/pom.xml b/pom.xml index ca0f27d..987150c 100644 --- a/pom.xml +++ b/pom.xml @@ -56,7 +56,7 @@ 2.18.1 methods - 3 + 10 config/single.testng.xml config/local.testng.xml From c809dbd9e1902f89f2218b7ec7501a8afb590296 Mon Sep 17 00:00:00 2001 From: leevardaro Date: Thu, 3 Feb 2022 18:11:53 -0500 Subject: [PATCH 18/23] removing user and key --- config/parallel.testng.xml | 2 +- config/suite.testng.xml | 2 +- pom.xml | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/config/parallel.testng.xml b/config/parallel.testng.xml index 65ad743..b35e533 100644 --- a/config/parallel.testng.xml +++ b/config/parallel.testng.xml @@ -1,6 +1,6 @@ - + diff --git a/config/suite.testng.xml b/config/suite.testng.xml index dad377a..109d50a 100644 --- a/config/suite.testng.xml +++ b/config/suite.testng.xml @@ -1,7 +1,7 @@ - + diff --git a/pom.xml b/pom.xml index 987150c..f05c140 100644 --- a/pom.xml +++ b/pom.xml @@ -56,7 +56,7 @@ 2.18.1 methods - 10 + 20 config/single.testng.xml config/local.testng.xml @@ -66,7 +66,7 @@ suitethreadpoolsize - 4 + 5 From 0ddf9278e8f18e48b743c1a9254090c26b83175a Mon Sep 17 00:00:00 2001 From: leevardaro Date: Thu, 3 Feb 2022 18:13:59 -0500 Subject: [PATCH 19/23] removing user and key --- config/suite.testng.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/config/suite.testng.xml b/config/suite.testng.xml index 109d50a..2c4a61b 100644 --- a/config/suite.testng.xml +++ b/config/suite.testng.xml @@ -1,7 +1,7 @@ - + @@ -18,7 +18,7 @@ - + From f920bddf77ee47813041996822614fb70d67bacf Mon Sep 17 00:00:00 2001 From: leevardaro Date: Mon, 7 Feb 2022 14:27:00 -0500 Subject: [PATCH 20/23] removing user and key --- config/parallel.testng.xml | 2 +- config/suite.testng.xml | 4 ++-- src/test/java/com/browserstack/BrowserStackTestNGTest.java | 2 -- src/test/resources/conf/suite.conf.json | 4 ++-- 4 files changed, 5 insertions(+), 7 deletions(-) diff --git a/config/parallel.testng.xml b/config/parallel.testng.xml index b35e533..24c4721 100644 --- a/config/parallel.testng.xml +++ b/config/parallel.testng.xml @@ -1,6 +1,6 @@ - + diff --git a/config/suite.testng.xml b/config/suite.testng.xml index 2c4a61b..365fdba 100644 --- a/config/suite.testng.xml +++ b/config/suite.testng.xml @@ -1,7 +1,7 @@ - + @@ -18,7 +18,7 @@ - + diff --git a/src/test/java/com/browserstack/BrowserStackTestNGTest.java b/src/test/java/com/browserstack/BrowserStackTestNGTest.java index d3d22c8..81682b3 100644 --- a/src/test/java/com/browserstack/BrowserStackTestNGTest.java +++ b/src/test/java/com/browserstack/BrowserStackTestNGTest.java @@ -63,8 +63,6 @@ public void setUp(String config_file, String environment) throws Exception { options.put("key", accessKey); l.start(options); } - String buildName = System.getenv("BROWSERSTACK_BUILD_NAME"); - capabilities.setCapability("build", buildName); driver = new RemoteWebDriver( new URL("http://" + username + ":" + accessKey + "@" + config.get("server") + "/wd/hub"), capabilities); diff --git a/src/test/resources/conf/suite.conf.json b/src/test/resources/conf/suite.conf.json index bba5e53..0f2cf98 100644 --- a/src/test/resources/conf/suite.conf.json +++ b/src/test/resources/conf/suite.conf.json @@ -1,7 +1,7 @@ { "server": "hub-cloud.browserstack.com", - "user": null, - "key": null, + "user": BROWSERSTACK_USERNAME, + "key": BROWSERSTACK_ACCESS_KEY, "capabilities": { "build": "browserstack-build-1", From d888450457c7c29b00a2a0673ef17b5cc367d33e Mon Sep 17 00:00:00 2001 From: leevardaro Date: Mon, 7 Feb 2022 14:34:20 -0500 Subject: [PATCH 21/23] removing user and key --- src/test/resources/conf/suite.conf.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/test/resources/conf/suite.conf.json b/src/test/resources/conf/suite.conf.json index 0f2cf98..7f19ce1 100644 --- a/src/test/resources/conf/suite.conf.json +++ b/src/test/resources/conf/suite.conf.json @@ -1,7 +1,7 @@ { "server": "hub-cloud.browserstack.com", - "user": BROWSERSTACK_USERNAME, - "key": BROWSERSTACK_ACCESS_KEY, + "user": "BROWSERSTACK_USERNAME", + "key": "BROWSERSTACK_ACCESS_KEY", "capabilities": { "build": "browserstack-build-1", From 9aa71fcaa03fc3e03397735519586f441bd998f9 Mon Sep 17 00:00:00 2001 From: leevardaro Date: Tue, 22 Feb 2022 14:59:34 -0600 Subject: [PATCH 22/23] add build name --- src/test/java/com/browserstack/BrowserStackTestNGTest.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/test/java/com/browserstack/BrowserStackTestNGTest.java b/src/test/java/com/browserstack/BrowserStackTestNGTest.java index 81682b3..50d2f75 100644 --- a/src/test/java/com/browserstack/BrowserStackTestNGTest.java +++ b/src/test/java/com/browserstack/BrowserStackTestNGTest.java @@ -55,6 +55,8 @@ public void setUp(String config_file, String environment) throws Exception { if (accessKey == null) { accessKey = (String) config.get("key"); } + String buildName = System.getenv("BROWSERSTACK_BUILD_NAME"); + capabilities.setCapability("build", buildName); if (capabilities.getCapability("browserstack.local") != null && capabilities.getCapability("browserstack.local") == "true") { From a4b9db9a21af47895871e76242ec751d63a8462a Mon Sep 17 00:00:00 2001 From: leevardaro Date: Tue, 22 Feb 2022 15:01:55 -0600 Subject: [PATCH 23/23] add build name --- config/parallel.testng.xml | 2 +- config/suite.testng.xml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/config/parallel.testng.xml b/config/parallel.testng.xml index 24c4721..65ad743 100644 --- a/config/parallel.testng.xml +++ b/config/parallel.testng.xml @@ -1,6 +1,6 @@ - + diff --git a/config/suite.testng.xml b/config/suite.testng.xml index 365fdba..2c4a61b 100644 --- a/config/suite.testng.xml +++ b/config/suite.testng.xml @@ -1,7 +1,7 @@ - + @@ -18,7 +18,7 @@ - +