Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor curation queries #343

Open
bruvellu opened this issue Oct 6, 2024 · 1 comment · Fixed by #344
Open

Refactor curation queries #343

bruvellu opened this issue Oct 6, 2024 · 1 comment · Fixed by #344
Assignees
Labels
bug Issues with bugs that need to be fixed improvement Issues with improvements for existing features
Milestone

Comments

@bruvellu
Copy link
Owner

bruvellu commented Oct 6, 2024

Updating curations for every taxon update is complex. The signals we set up are not handling well all the edge cases. Perhaps a simpler way is, instead of setting the curation relationship to every taxon, simply fetch curations from the ancestors. In this way, we don't need to handle the high burden of updating at every transaction.

This issue will attempt to solve the above and address #341. But before, there's a log of cleaning up to do. Mainly, moving the logic for taxon update, media synchronization, and curation update to Taxon methods. This is also a first step towards reducing the 6 redundant copies of the code in the views upload_media_step2, editing_media_details, editing_media_list, my_media_details, revision_media_details, my_curations_media_details.

@bruvellu bruvellu self-assigned this Oct 6, 2024
@bruvellu bruvellu added bug Issues with bugs that need to be fixed improvement Issues with improvements for existing features labels Oct 6, 2024
@bruvellu bruvellu added this to the v2.0.0 milestone Oct 6, 2024
@bruvellu
Copy link
Owner Author

bruvellu commented Oct 10, 2024

The cleaning up is done with 3a4ecd2. This actually closes #341.

Now I need to find all the places where curations are being queried from Taxon and Media and update the logic to fetch all curations from the ancestors.

But I'll already merge the branch to develop to already push this code to staging for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues with bugs that need to be fixed improvement Issues with improvements for existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant