Small bug in the merger when selecting the output trace name

[valentin-seitz]

Using Extrae v4.2.1 the usage of the merger mpi2prv prints the follwing:

Usage: mpi2prv inputfile1 ... [--] inputfileN [-o <OutputFile>] [otheroptions]
       mpi2prv -f file.mpits [-o <OutputFile>] [otheroptions]
       mpi2prv -h
Options:
    -h                   Get this help.
    -v                   Increase verbosity.
    -absolute-counters   Emit hardware counters in absolute form in addition to relative form.
    -o file              Output trace file name.
    -e file              Uses the executable file to obtain some information.
    ...

As a paraver trace is not a single file, but 3 namely the <tracename>.{prv,pcf,row} I would expect the -o option to take in the <tracename> excluding the file ending, as the program only takes 1 output name.

When executing the merger like mpi2prv -f TRACE.mpits -o testtrace I obtain the following files:

machine@user:~/extrae_run$ ls
testt.pcf  testt.row  testtrace

This however is not really expected and leads to a faulty trace which Paraver is not able to open, as the implicit naming conventions are violated.
I would expect the files testtrace.pcf testttrace.row and testtrace.prv to be generated.

A simple check if the filename ends in .prv should be able to fix this.

Additionally, if you run it with a filename with less than 4 letters like mpi2prv -f TRACE.mpits -o tes a buffer overflow get detected as:

mpi2prv: Elapsed time removing temporal files: 0 hours 0 minutes 0 seconds
*** buffer overflow detected ***: terminated
Aborted (core dumped)

A quick gdb backtrace spotted the culprid here:

extrae/src/merger/paraver/trace_to_prv.c

Line 677 in 4556241

strcpy (tmp, ".pcf");