From c1b96664294e6622e981a9e53c433dd9f77bcb94 Mon Sep 17 00:00:00 2001 From: Brian Tambara Date: Sat, 20 Apr 2024 12:44:38 -0700 Subject: [PATCH] removed the offset and limit from method parameters for get_all_players --- api/src/player/crud/player_crud.py | 18 ++++++------------ api/src/player/routers/players_endpoints.py | 4 +--- 2 files changed, 7 insertions(+), 15 deletions(-) diff --git a/api/src/player/crud/player_crud.py b/api/src/player/crud/player_crud.py index d40c0de..d59f286 100644 --- a/api/src/player/crud/player_crud.py +++ b/api/src/player/crud/player_crud.py @@ -13,10 +13,8 @@ def get_player(db: Session, id: int) -> Optional[Player]: return db.query(Player).filter(Player.id == id).first() # type: ignore[no-any-return] -def get_all_players( - db: Session, position: str | None = None, skip: int = 0, limit: int = 100 -) -> List[Player]: - all_players = db.query(Player).offset(skip).limit(limit).all() +def get_all_players(db: Session, position: str | None = None) -> List[Player]: + all_players = db.query(Player).all() if len(all_players) == 0 and settings.environment != "TEST": for team in statsapi.get("teams", {"sportId": 1})[ @@ -41,19 +39,15 @@ def get_all_players( ) create_player(db, player_create) - all_players = ( - db.query(Player).offset(skip).limit(limit).all() - ) # pragma: no cover (This will call MLB api, so for now I'm not testing this) + all_players = db.query( + Player + ).all() # pragma: no cover (This will call MLB api, so for now I'm not testing this) if not position: return all_players # type: ignore[no-any-return] else: return ( # type: ignore[no-any-return] - db.query(Player) - .filter(Player.primary_position_code == position) - .offset(skip) - .limit(limit) - .all() + db.query(Player).filter(Player.primary_position_code == position).all() ) diff --git a/api/src/player/routers/players_endpoints.py b/api/src/player/routers/players_endpoints.py index 511181f..57cab88 100644 --- a/api/src/player/routers/players_endpoints.py +++ b/api/src/player/routers/players_endpoints.py @@ -127,10 +127,8 @@ async def read_all_players( *, db: Session = Depends(get_db), position: str | None = None, - skip: int = 0, - limit: int = 100, ) -> List[Player]: """ Get all players. """ - return player_crud.get_all_players(db=db, position=position, skip=skip, limit=limit) + return player_crud.get_all_players(db=db, position=position)