Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor class names of clients and responses (breaking change, major release) #100

Open
ndeet opened this issue Feb 22, 2023 · 2 comments
Open

Refactor class names of clients and responses (breaking change, major release) #100

ndeet opened this issue Feb 22, 2023 · 2 comments

Comments

@ndeet
Copy link
Collaborator

ndeet commented Feb 22, 2023

We currently have conflicting class names making the need to alias them. E.g. \Client\User and \Result\User. We should follow similar pattern than Laravel and be explicit like UserClient and UserResult.
@ndeet ndeet mentioned this issue Feb 22, 2023
Merged
@ndeet
Copy link
Collaborator Author

ndeet commented Mar 3, 2023

In the ApiKey client class, fix camelCase for createApikey to createApiKey

@utxo-one
Copy link
Contributor

utxo-one commented May 1, 2023

Agreed 100%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ndeet @utxo-one