Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReturnCode always 0 when run against multiple globs #117

Open
robellegate opened this issue Nov 4, 2019 · 2 comments
Open

ReturnCode always 0 when run against multiple globs #117

robellegate opened this issue Nov 4, 2019 · 2 comments
Labels

Comments

@robellegate
Copy link

If you use multiple glob patterns, write-good will always return 0 even if there's grammar mistakes.

This is what happens when using multiple globs, *.md and ./docs/*.md:
Example

$ write-good *.md ./docs/*.md --parse --no-passive --no-adverb --no-tooWordy --no-cliches
README.md:14:29:"various" is a weasel word
README.md:15:6:"and" is repeated






$ echo $?
0

Whereas this is what happens when run with only one glob, *.md:

$ write-good *.md --parse --no-passive --no-adverb --no-tooWordy --no-cliches
README.md:14:29:"various" is a weasel word
README.md:15:6:"and" is repeated
$ echo $?
255
@robellegate
Copy link
Author

robellegate commented Nov 4, 2019

This is causing issues where the CI/CD pipeline will succeed even when grammar issues are detected

@RichardLitt
Copy link
Collaborator

Thanks for pointing this out, @robellegate. A PR fix would be great. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants