Loosen version restrictions #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- lower minimum Python supported to 3.8
- removed poetry.lock
- prevented installation of library in existing envs without serious corruption
- see https://python-poetry.org/docs/basic-usage/#as-a-library-developer
Verified all tests and pre-commit hooks pass
Author
|
See also: bubblesub/ass_parser#1, bubblesub/ass_renderer#3 I went down this path trying to implement a non-strict mode (w/ tests) to address #9 but I couldn't get these libs to install in any of my python environments were I wanted to use them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified all tests and pre-commit hooks pass
Tested on various Python versions on Windows, Ubuntu, macOS