From 0dee2bf8f78a13a0c556cc33df75b74bbb9dac00 Mon Sep 17 00:00:00 2001
From: Ivascu Madalin <madalin.ivascu@arnia.ro>
Date: Tue, 28 Nov 2023 16:02:30 +0200
Subject: [PATCH 1/2] BP-3179 Add support for "External Payments"

---
 example/transactions/externalPayment.php      | 19 ++++++
 .../ExternalPayment/ExternalPayment.php       | 30 ++++++++
 src/PaymentMethods/PaymentMethodFactory.php   | 68 ++++++++++---------
 .../Buckaroo/Payments/ExternalPaymentTest.php | 56 +++++++++++++++
 4 files changed, 140 insertions(+), 33 deletions(-)
 create mode 100644 example/transactions/externalPayment.php
 create mode 100644 src/PaymentMethods/ExternalPayment/ExternalPayment.php
 create mode 100644 tests/Buckaroo/Payments/ExternalPaymentTest.php

diff --git a/example/transactions/externalPayment.php b/example/transactions/externalPayment.php
new file mode 100644
index 0000000..85a881f
--- /dev/null
+++ b/example/transactions/externalPayment.php
@@ -0,0 +1,19 @@
+<?php
+
+require_once __DIR__.'/../bootstrap.php';
+
+use Buckaroo\BuckarooClient;
+
+$buckaroo = new BuckarooClient($_ENV['BPE_WEBSITE_KEY'], $_ENV['BPE_SECRET_KEY']);
+
+$response = $buckaroo->method('externalPayment')->pay([
+    'invoice' => uniqid(),
+    'amountDebit' => 10.10,
+    'channel' => 'BackOffice'
+]);
+
+$buckaroo->method('externalPayment')->refund([
+    'amountCredit' => 10,
+    'invoice' => 'testinvoice 123',
+    'originalTransactionKey' => $response->getTransactionKey(),
+]);
\ No newline at end of file
diff --git a/src/PaymentMethods/ExternalPayment/ExternalPayment.php b/src/PaymentMethods/ExternalPayment/ExternalPayment.php
new file mode 100644
index 0000000..f10e6d0
--- /dev/null
+++ b/src/PaymentMethods/ExternalPayment/ExternalPayment.php
@@ -0,0 +1,30 @@
+<?php
+/*
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the MIT License
+ * It is available through the world-wide-web at this URL:
+ * https://tldrlegal.com/license/mit-license
+ * If you are unable to obtain it through the world-wide-web, please send an email
+ * to support@buckaroo.nl so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade this module to newer
+ * versions in the future. If you wish to customize this module for your
+ * needs please contact support@buckaroo.nl for more information.
+ *
+ * @copyright Copyright (c) Buckaroo B.V.
+ * @license   https://tldrlegal.com/license/mit-license
+ */
+
+declare(strict_types=1);
+
+namespace Buckaroo\PaymentMethods\ExternalPayment;
+
+use Buckaroo\PaymentMethods\PayablePaymentMethod;
+
+class ExternalPayment extends PayablePaymentMethod
+{
+    protected string $paymentName = 'ExternalPayment';
+}
diff --git a/src/PaymentMethods/PaymentMethodFactory.php b/src/PaymentMethods/PaymentMethodFactory.php
index c675167..4fe4c0a 100644
--- a/src/PaymentMethods/PaymentMethodFactory.php
+++ b/src/PaymentMethods/PaymentMethodFactory.php
@@ -20,51 +20,52 @@
 
 namespace Buckaroo\PaymentMethods;
 
+use Buckaroo\Transaction\Client;
+use Buckaroo\PaymentMethods\EPS\EPS;
+use Buckaroo\PaymentMethods\In3\In3;
+use Buckaroo\PaymentMethods\KBC\KBC;
+use Buckaroo\PaymentMethods\iDin\iDin;
+use Buckaroo\PaymentMethods\SEPA\SEPA;
+use Buckaroo\PaymentMethods\iDeal\iDeal;
+use Buckaroo\PaymentMethods\MBWay\MBWay;
+use Buckaroo\PaymentMethods\Tinka\Tinka;
 use Buckaroo\Exceptions\BuckarooException;
-use Buckaroo\PaymentMethods\Afterpay\Afterpay;
-use Buckaroo\PaymentMethods\AfterpayDigiAccept\AfterpayDigiAccept;
 use Buckaroo\PaymentMethods\Alipay\Alipay;
-use Buckaroo\PaymentMethods\ApplePay\ApplePay;
-use Buckaroo\PaymentMethods\Bancontact\Bancontact;
-use Buckaroo\PaymentMethods\BankTransfer\BankTransfer;
+use Buckaroo\PaymentMethods\In3Old\In3Old;
+use Buckaroo\PaymentMethods\Paypal\Paypal;
+use Buckaroo\PaymentMethods\Sofort\Sofort;
+use Buckaroo\PaymentMethods\Thunes\Thunes;
 use Buckaroo\PaymentMethods\Belfius\Belfius;
 use Buckaroo\PaymentMethods\Billink\Billink;
-use Buckaroo\PaymentMethods\BuckarooVoucher\BuckarooVoucher;
-use Buckaroo\PaymentMethods\BuckarooWallet\BuckarooWallet;
-use Buckaroo\PaymentMethods\CreditCard\CreditCard;
-use Buckaroo\PaymentMethods\CreditClick\CreditClick;
-use Buckaroo\PaymentMethods\CreditManagement\CreditManagement;
-use Buckaroo\PaymentMethods\Emandates\Emandates;
-use Buckaroo\PaymentMethods\EPS\EPS;
-use Buckaroo\PaymentMethods\MBWay\MBWay;
-use Buckaroo\PaymentMethods\GiftCard\GiftCard;
 use Buckaroo\PaymentMethods\Giropay\Giropay;
-use Buckaroo\PaymentMethods\iDeal\iDeal;
 use Buckaroo\PaymentMethods\iDealQR\iDealQR;
-use Buckaroo\PaymentMethods\iDin\iDin;
-use Buckaroo\PaymentMethods\In3\In3;
-use Buckaroo\PaymentMethods\In3Old\In3Old;
-use Buckaroo\PaymentMethods\KBC\KBC;
+use Buckaroo\PaymentMethods\Surepay\Surepay;
+use Buckaroo\PaymentMethods\Trustly\Trustly;
+use Buckaroo\PaymentMethods\Afterpay\Afterpay;
+use Buckaroo\PaymentMethods\ApplePay\ApplePay;
+use Buckaroo\PaymentMethods\GiftCard\GiftCard;
 use Buckaroo\PaymentMethods\KlarnaKP\KlarnaKP;
+use Buckaroo\PaymentMethods\Payconiq\Payconiq;
+use Buckaroo\PaymentMethods\Emandates\Emandates;
 use Buckaroo\PaymentMethods\KlarnaPay\KlarnaPay;
-use Buckaroo\PaymentMethods\Marketplaces\Marketplaces;
+use Buckaroo\PaymentMethods\WeChatPay\WeChatPay;
+use Buckaroo\PaymentMethods\Bancontact\Bancontact;
+use Buckaroo\PaymentMethods\CreditCard\CreditCard;
 use Buckaroo\PaymentMethods\Multibanco\Multibanco;
-use Buckaroo\PaymentMethods\NoServiceSpecifiedPayment\NoServiceSpecifiedPayment;
-use Buckaroo\PaymentMethods\Payconiq\Payconiq;
-use Buckaroo\PaymentMethods\PaymentInitiation\PaymentInitiation;
-use Buckaroo\PaymentMethods\Paypal\Paypal;
+use Buckaroo\PaymentMethods\Przelewy24\Przelewy24;
+use Buckaroo\PaymentMethods\CreditClick\CreditClick;
 use Buckaroo\PaymentMethods\PayPerEmail\PayPerEmail;
 use Buckaroo\PaymentMethods\PointOfSale\PointOfSale;
-use Buckaroo\PaymentMethods\Przelewy24\Przelewy24;
-use Buckaroo\PaymentMethods\SEPA\SEPA;
-use Buckaroo\PaymentMethods\Sofort\Sofort;
+use Buckaroo\PaymentMethods\BankTransfer\BankTransfer;
+use Buckaroo\PaymentMethods\Marketplaces\Marketplaces;
 use Buckaroo\PaymentMethods\Subscriptions\Subscriptions;
-use Buckaroo\PaymentMethods\Surepay\Surepay;
-use Buckaroo\PaymentMethods\Thunes\Thunes;
-use Buckaroo\PaymentMethods\Tinka\Tinka;
-use Buckaroo\PaymentMethods\Trustly\Trustly;
-use Buckaroo\PaymentMethods\WeChatPay\WeChatPay;
-use Buckaroo\Transaction\Client;
+use Buckaroo\PaymentMethods\BuckarooWallet\BuckarooWallet;
+use Buckaroo\PaymentMethods\BuckarooVoucher\BuckarooVoucher;
+use Buckaroo\PaymentMethods\ExternalPayment\ExternalPayment;
+use Buckaroo\PaymentMethods\CreditManagement\CreditManagement;
+use Buckaroo\PaymentMethods\PaymentInitiation\PaymentInitiation;
+use Buckaroo\PaymentMethods\AfterpayDigiAccept\AfterpayDigiAccept;
+use Buckaroo\PaymentMethods\NoServiceSpecifiedPayment\NoServiceSpecifiedPayment;
 
 class PaymentMethodFactory
 {
@@ -107,6 +108,7 @@ class PaymentMethodFactory
         PayPerEmail::class => ['payperemail'],
         PaymentInitiation::class => ['paymentinitiation','paybybank'],
         EPS::class => ['eps'],
+        ExternalPayment::class => ['externalpayment'],
         Emandates::class => ['emandates'],
         Sofort::class => ['sofort', 'sofortueberweisung'],
         Tinka::class => ['tinka'],
diff --git a/tests/Buckaroo/Payments/ExternalPaymentTest.php b/tests/Buckaroo/Payments/ExternalPaymentTest.php
new file mode 100644
index 0000000..f2994fa
--- /dev/null
+++ b/tests/Buckaroo/Payments/ExternalPaymentTest.php
@@ -0,0 +1,56 @@
+<?php
+/*
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the MIT License
+ * It is available through the world-wide-web at this URL:
+ * https://tldrlegal.com/license/mit-license
+ * If you are unable to obtain it through the world-wide-web, please send an email
+ * to support@buckaroo.nl so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade this module to newer
+ * versions in the future. If you wish to customize this module for your
+ * needs please contact support@buckaroo.nl for more information.
+ *
+ * @copyright Copyright (c) Buckaroo B.V.
+ * @license   https://tldrlegal.com/license/mit-license
+ */
+
+namespace Tests\Buckaroo\Payments;
+
+use Tests\Buckaroo\BuckarooTestCase;
+
+class ExternalPaymentTest extends BuckarooTestCase
+{
+    /**
+     * @return void
+     * @test
+     */
+    public function it_creates_a_external_payment()
+    {
+        $response = $this->buckaroo->method('externalPayment')->pay([
+            'invoice' => uniqid(),
+            'amountDebit' => 11.10,
+            'channel' => 'BACKOFFICE'
+        ]);
+
+        $this->assertTrue($response->isSuccess());
+    }
+
+    /**
+     * @test
+     */
+    public function it_creates_a_external_payment_refund()
+    {
+        $response = $this->buckaroo->method('externalPayment')->refund([
+            'amountCredit' => 10,
+            'invoice' => 'testinvoice 123',
+            'description' => 'refund',
+            'originalTransactionKey' => '2D04704995B74D679AACC59F87XXXXXX',
+        ]);
+
+        $this->assertTrue($response->isFailed());
+    }
+}

From 32688662aef282d2bb29a8b569a103f41359bd43 Mon Sep 17 00:00:00 2001
From: Ivascu Madalin <madalin.ivascu@arnia.ro>
Date: Tue, 5 Dec 2023 15:46:49 +0200
Subject: [PATCH 2/2] rename test function

---
 tests/Buckaroo/Payments/ExternalPaymentTest.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/Buckaroo/Payments/ExternalPaymentTest.php b/tests/Buckaroo/Payments/ExternalPaymentTest.php
index f2994fa..5b0338c 100644
--- a/tests/Buckaroo/Payments/ExternalPaymentTest.php
+++ b/tests/Buckaroo/Payments/ExternalPaymentTest.php
@@ -42,7 +42,7 @@ public function it_creates_a_external_payment()
     /**
      * @test
      */
-    public function it_creates_a_external_payment_refund()
+    public function it_creates_a_external_refund()
     {
         $response = $this->buckaroo->method('externalPayment')->refund([
             'amountCredit' => 10,