-
|
Why are the StatusCode and the StatusMessage of AdmissionResult (and therefore also e.g. ValidationResult) internal and there is no getter whatsoever for them, although they can be set by the user? It makes it very hard to write unit tests e.g. for a ValidationWebhook. |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 2 replies
-
|
Uhm... to be honest, there is no real reason. I just thought that adding things to the public is not a breaking change while - for some reason - removing things is a breaking change. Therefore I just exposed everything that is absolutely necessary. Do you think it would make things easier if those fields were public? |
Beta Was this translation helpful? Give feedback.
-
|
It would make it easier to write proper unit tests for the handler methods that check for the proper ValidationResult. |
Beta Was this translation helpful? Give feedback.
-
|
That's a good reason. |
Beta Was this translation helpful? Give feedback.
Uhm... to be honest, there is no real reason. I just thought that adding things to the public is not a breaking change while - for some reason - removing things is a breaking change. Therefore I just exposed everything that is absolutely necessary.
Do you think it would make things easier if those fields were public?