Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove excess data fetching on /training/common-intents page #743

Open
2 tasks
Tracked by #700
IgorKrupenja opened this issue Dec 9, 2024 · 3 comments
Open
2 tasks
Tracked by #700

Remove excess data fetching on /training/common-intents page #743

IgorKrupenja opened this issue Dec 9, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request v2.0.2

Comments

@IgorKrupenja
Copy link
Collaborator

IgorKrupenja commented Dec 9, 2024

Note

This is a sub-issue of #700

Acceptance Criteria

@IgorKrupenja IgorKrupenja self-assigned this Dec 9, 2024
@turnerrainer turnerrainer changed the title Remove excess response fetching on /training/intents page Remove excess response fetching on /training/common-intents page Dec 10, 2024
@turnerrainer turnerrainer added v2.0.2 enhancement New feature or request labels Dec 10, 2024
@IgorKrupenja IgorKrupenja changed the title Remove excess response fetching on /training/common-intents page Remove excess data fetching on /training/common-intents page Dec 10, 2024
@IgorKrupenja
Copy link
Collaborator Author

IgorKrupenja commented Dec 10, 2024

  • Should use the common IntentDetails component implemented in Remove excess intent fetching on /training/intents page #731 to remove all duplicate code. The common component might need some tweaks.
  • Remove unused common.yaml?
  • Remove unused full.yaml and check related stuff. get_intents_with_examples will not be used too.
  • rename examples_count to examplesCount when possible with changes in CommonIntents

@IgorKrupenja
Copy link
Collaborator Author

Related PR: #755

@rasmusei rasmusei moved this from In Progress to In Review in Bürokratt Sprint Dec 12, 2024
@rasmusei rasmusei moved this from In Review to To Deploy in Bürokratt Sprint Dec 13, 2024
@varmoh varmoh moved this from To Deploy to Acceptance Testing in Bürokratt Sprint Dec 16, 2024
@ffrose ffrose assigned ffrose and jaX10bt and unassigned IgorKrupenja Jan 9, 2025
@IgorKrupenja
Copy link
Collaborator Author

Please test the following:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2.0.2
Projects
Status: Acceptance Testing
Development

No branches or pull requests

4 participants