Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Slot rules in Training Module not functioning as intended #771

Open
jaX10bt opened this issue Dec 30, 2024 · 1 comment · Fixed by #773
Open

[BUG] Slot rules in Training Module not functioning as intended #771

jaX10bt opened this issue Dec 30, 2024 · 1 comment · Fixed by #773
Assignees
Labels
bug Something isn't working v2.0.2

Comments

@jaX10bt
Copy link
Collaborator

jaX10bt commented Dec 30, 2024

Bug description:
When creating/modifying a rule that checks slots using slot_was_set, the Rasa rules syntax is broken due to a missing hyphen (-) before the slot name. This is an example of a broken rule:

  - rule: common_teenus_rk_hääletus_viimased
    steps:
      - slot_was_set:
          rk_hääletused: true
      - intent: common_teenus_rk_hääletus
      - action: utter_common_teenus_rk_hääletus_viimased
      - action: action_restart

Expected behavior:
This is how the rule should be:

  - rule: common_teenus_rk_hääletus_viimased
    steps:
      - slot_was_set:
          - rk_hääletused: true
      - intent: common_teenus_rk_hääletus
      - action: utter_common_teenus_rk_hääletus_viimased
      - action: action_restart

Screenshots:

Additional information:
When looking at the http response, a rule that is not broken has the slot name and value in an array ({slot_was_set: [{rk_hääletused: true}]}), while for a broken rule that is not the case ({slot_was_set: {rk_hääletused: true}})

@jaX10bt jaX10bt added the bug Something isn't working label Dec 30, 2024
@jaX10bt jaX10bt moved this to Ready in Bürokratt Sprint Dec 30, 2024
@jaX10bt jaX10bt added the v2.0.2 label Dec 30, 2024
@ExiRain
Copy link
Collaborator

ExiRain commented Dec 31, 2024

Wrapped returning value for ruleset into array looks good for provided case:

#773

@rasmusei rasmusei moved this from Ready to In Review in Bürokratt Sprint Jan 2, 2025
@rasmusei rasmusei linked a pull request Jan 4, 2025 that will close this issue
@rasmusei rasmusei moved this from In Review to To Deploy in Bürokratt Sprint Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v2.0.2
Projects
Status: To Deploy
Development

Successfully merging a pull request may close this issue.

2 participants