Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All fields are optional in generated messages for proto2 schemas #549

Closed
joemckenney opened this issue Aug 4, 2023 · 2 comments
Closed

All fields are optional in generated messages for proto2 schemas #549

joemckenney opened this issue Aug 4, 2023 · 2 comments

Comments

@joemckenney
Copy link

When using proto2 in a project, we expect the generated code to encode the optionality of a field in a message.

Currently, all fields in the generated messages are optional (which makes sense in proto3 but doesn't quite align with a proto2 schema).
@czabaj
Copy link

czabaj commented Oct 9, 2023

Seems to be related to #414

@joemckenney
Copy link
Author

Spot on @czabaj, #414 is the same. Closing this one as a duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joemckenney @czabaj