Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the type
DescSet
, a set of descriptors with convenient accessors to look up descriptors by name.This type is the successor to
DescriptorSet
and registries, and combines the features of both.For example, if generated files exports the messages
User
andFoo
, a set of the descriptors can be created with:To create a set of descriptors from a
google.protobuf.FileDescriptorSet
message:This creates a
DescSet
that also includes file descriptors, aDescFileSet
. The old functioncreateDescriptorSet()
and the interfaceDescriptorSet
are not removed by this PR, and continue to work as expected.Descriptor sets can be merged by passing multiple input sets to the variadic function
createDescSet()
orcreateDescFileSet()
:This feature makes it trivial to create "registries" from multiple generated file descriptors. If a descriptor is given multiple times (identified by the same type name), the one given last wins.