Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: change the navigation bar colour (esp. for night mode) #319

Open
C6H7NO2 opened this issue Dec 22, 2021 · 0 comments
Open

Android: change the navigation bar colour (esp. for night mode) #319

C6H7NO2 opened this issue Dec 22, 2021 · 0 comments

Comments

@C6H7NO2
Copy link

C6H7NO2 commented Dec 22, 2021

CoolReader seems to enforce the white (or perhaps the default) colour for the navigation bar (the one with the Back and Home buttons at the bottom). This applies to the phones with 'soft' nav bar, which is nearly all the modern ones.

This is really bad, particularly in the night mode: bright white nav bar makes night mode unusable.

One solution is to use full screen mode. But it's not always good: I like to have permanent single-click access to the navigation buttons. (Nav bar can usually be 'pulled' by a gesture, but it's too slow).

Another solution is to use Dark mode in Android options. But this affects everything, not always for the good.

There are third-party apps to overlay a custom nav bar (e.g. "Navbar Apps"), but CoolReader somehow defeats it.

So. Ideally, CoolReader should change the nav bar colour according to the page background colour - at least when solid colour is selected. (For textured background, there could be several ways: a dedicated option, averaging the image colour, or something. I don't personally care). And, importantly, it should switch it accordingly when switching between day and night modes.

Apparently, this is relatively simple.

If doing this is not possible for some reason, I'd beg to change the static colour to always black. This is certainly better than always white: black is just a blank screen, a placeholder for buttons (the way it was on older phones with permanent buttons). As I said, without it the night mode is pretty much useless (unless some inconvenient tricks are applied).

Repository owner deleted a comment from plotn Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant