Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trap can use native composer.json "version" property, to read current package version. #90

Open
lotyp opened this issue May 21, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@lotyp
Copy link
Member

lotyp commented May 21, 2024

Problem

Here is composer documentation.

https://getcomposer.org/doc/articles/troubleshooting.md#root-package-version-detection

Also, if not set, when working with project locally, you will see this kind of error.

Screenshot 2024-05-21 at 21 45 11

Resolution

As we have release-please action, it will use composer.json by default, if it will find "version" property inside composer.json and this action will auto-bump version.

"version" should be added to composer.json.

@lotyp lotyp added the bug Something isn't working label May 21, 2024
@lotyp lotyp self-assigned this May 21, 2024
@roxblnfk
Copy link
Member

roxblnfk commented Jul 1, 2024

Looks like it works well right now with releases and phar. Can we close the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants