Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge and extend ApiSession.getLiveContract and ApiSession.getLiveJson #119

Open
3Nigma opened this issue Oct 21, 2022 · 0 comments
Open
Assignees
Labels
braking-changes This work will introduce changes that brake backwards compatibility contracts LiveContract/Smart contract related enhancement New feature or request node-js Affecting NodeJs runtime environments web Affecting Web runtime environments
Milestone

Comments

@3Nigma
Copy link
Contributor

3Nigma commented Oct 21, 2022

We have ApiSession methods to retrieve live instances of type Contract and Json, but there aren't any to retrieve LiveAccounts, LiveFiles, LiveTokens and LiveTopics. We need to support these as well.

We should do it by merging ApiSession.getLiveContract and ApiSession.getLiveJson into a single, overloaded, ApiSession.getLive method. One overload for each type of entity.

Its signature could be something like: ApiSession.getLive(LiveEntityType, args): Promise<-live-entity-> which would lead to the following 2 methods for the existing Json/Contract retrievals:

  • ApiSession.getLive(LiveEntityType.Contract, id, abi = []): Promise<LiveContract>
  • ApiSession.getLive(LiveEntityType.Json, id): Promise<LiveJson>
@3Nigma 3Nigma added enhancement New feature or request heavy work Heavy work is expected for this contracts LiveContract/Smart contract related node-js Affecting NodeJs runtime environments web Affecting Web runtime environments braking-changes This work will introduce changes that brake backwards compatibility labels Oct 21, 2022
@3Nigma 3Nigma added this to the Back-burner milestone Oct 21, 2022
@3Nigma 3Nigma removed the heavy work Heavy work is expected for this label Oct 21, 2022
@3Nigma 3Nigma modified the milestones: Back-burner, 0.8.1 Oct 21, 2022
@3Nigma 3Nigma self-assigned this Oct 21, 2022
@3Nigma 3Nigma modified the milestones: 0.8.1, 0.8.2 Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
braking-changes This work will introduce changes that brake backwards compatibility contracts LiveContract/Smart contract related enhancement New feature or request node-js Affecting NodeJs runtime environments web Affecting Web runtime environments
Projects
None yet
Development

No branches or pull requests

1 participant