Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove setMaxNodesPerTransaction when defining Client #136

Open
victorholo opened this issue Mar 21, 2023 · 0 comments
Open

Remove setMaxNodesPerTransaction when defining Client #136

victorholo opened this issue Mar 21, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@victorholo
Copy link
Contributor

We have added a setMaxNodesPerTransaction together with a TODO in HederaNetwork.ts file at line 105-106.
This was a fix for ticket hiero-ledger/hiero-sdk-js#953 opened in hedera-sdk-js repo which was since then integrated and this the setter is no longer necessary.

We need to remove it from our HederaNetwork definition of Client.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

136-remove-setmaxnodespertransaction-when-defining-client buidler-labs/hashgraph-venin-js
1 participant
@victorholo