Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-case error? pass-occurrences_override_the_type_classification_per_system_1_3 #225

Closed
I-Sokolov opened this issue Dec 10, 2023 · 4 comments
Closed

test-case error? pass-occurrences_override_the_type_classification_per_system_1_3 #225

I-Sokolov opened this issue Dec 10, 2023 · 4 comments

Comments

@I-Sokolov
Copy link
Contributor

I-Sokolov commented Dec 10, 2023 •
edited
Loading

IDS requires any IfcWall must have classification ref "11".
IfcWall #4 has no classification reference itself nor by type.
Should not test-case fail?
@I-Sokolov I-Sokolov mentioned this issue Dec 10, 2023
Closed
@andyward
Copy link
Contributor

I think this was logged already as #108

@I-Sokolov
Copy link
Contributor Author

I-Sokolov commented Dec 12, 2023 •
edited
Loading

Yes, @pasi-paasiala noted it fixed it but I'm still observing.

@andyward
Copy link
Contributor

Yes, but I think Pasi suggested it be fixed for 1.0 - I think there's a PR to regen the test cases and hope it can be picked up with that: #192. Have added some notes to that PR linking yours in.

@andyward andyward mentioned this issue Feb 27, 2024
Merged
@CBenghi
Copy link
Contributor

CBenghi commented Feb 28, 2024

I think this one has been fixed in #240 which we hope to merge soon. Closing this as duplicate, anyway.

@CBenghi CBenghi closed this as completed Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andyward @CBenghi @I-Sokolov