diff --git a/go.mod b/go.mod index 03771dee..03832f8f 100644 --- a/go.mod +++ b/go.mod @@ -1,6 +1,8 @@ module github.com/buildkite/cli/v3 -go 1.20 +go 1.21 + +toolchain go1.21.6 require ( github.com/AlecAivazis/survey/v2 v2.3.7 @@ -36,6 +38,7 @@ require ( github.com/go-git/gcfg v1.5.1-0.20230307220236-3a3c6141e376 // indirect github.com/go-git/go-billy/v5 v5.5.0 // indirect github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect + github.com/golangci/golangci-lint v1.57.1 // indirect github.com/google/go-querystring v1.0.0 // indirect github.com/h2non/parth v0.0.0-20190131123155-b4df798d6542 // indirect github.com/hashicorp/hcl v1.0.0 // indirect @@ -46,7 +49,7 @@ require ( github.com/lucasb-eyer/go-colorful v1.2.0 // indirect github.com/magiconair/properties v1.8.7 // indirect github.com/mattn/go-colorable v0.1.13 // indirect - github.com/mattn/go-isatty v0.0.18 // indirect + github.com/mattn/go-isatty v0.0.20 // indirect github.com/mattn/go-localereader v0.0.1 // indirect github.com/mattn/go-runewidth v0.0.15 // indirect github.com/mgutz/ansi v0.0.0-20170206155736-9520e82c474b // indirect @@ -54,7 +57,7 @@ require ( github.com/muesli/ansi v0.0.0-20211018074035-2e021307bc4b // indirect github.com/muesli/cancelreader v0.2.2 // indirect github.com/muesli/termenv v0.15.2 // indirect - github.com/pelletier/go-toml/v2 v2.1.0 // indirect + github.com/pelletier/go-toml/v2 v2.2.0 // indirect github.com/pjbgf/sha1cd v0.3.0 // indirect github.com/rivo/uniseg v0.4.7 // indirect github.com/sagikazarmark/locafero v0.4.0 // indirect @@ -77,7 +80,7 @@ require ( golang.org/x/sys v0.15.0 // indirect golang.org/x/term v0.15.0 // indirect golang.org/x/text v0.14.0 // indirect - golang.org/x/tools v0.13.0 // indirect + golang.org/x/tools v0.19.0 // indirect gopkg.in/ini.v1 v1.67.0 // indirect gopkg.in/warnings.v0 v0.1.2 // indirect ) diff --git a/go.sum b/go.sum index e15430a6..ba3b3adb 100644 --- a/go.sum +++ b/go.sum @@ -98,6 +98,8 @@ github.com/mattn/go-isatty v0.0.8/go.mod h1:Iq45c/XA43vh69/j3iqttzPXn0bhXyGjM0Hd github.com/mattn/go-isatty v0.0.16/go.mod h1:kYGgaQfpe5nmfYZH+SKPsOc2e4SrIfOl2e/yFXSvRLM= github.com/mattn/go-isatty v0.0.18 h1:DOKFKCQ7FNG2L1rbrmstDN4QVRdS89Nkh85u68Uwp98= github.com/mattn/go-isatty v0.0.18/go.mod h1:W+V8PltTTMOvKvAeJH7IuucS94S2C6jfK/D7dTCTo3Y= +github.com/mattn/go-isatty v0.0.20 h1:xfD0iDuEKnDkl03q4limB+vH+GxLEtL/jb4xVJSWWEY= +github.com/mattn/go-isatty v0.0.20/go.mod h1:W+V8PltTTMOvKvAeJH7IuucS94S2C6jfK/D7dTCTo3Y= github.com/mattn/go-localereader v0.0.1 h1:ygSAOl7ZXTx4RdPYinUpg6W99U8jWvWi9Ye2JC/oIi4= github.com/mattn/go-localereader v0.0.1/go.mod h1:8fBrzywKY7BI3czFoHkuzRoWE9C+EiG4R1k4Cjx5p88= github.com/mattn/go-runewidth v0.0.12/go.mod h1:RAqKPSqVFrSLVXbA8x7dzmKdmGzieGRCM46jaSJTDAk= @@ -120,6 +122,8 @@ github.com/nbio/st v0.0.0-20140626010706-e9e8d9816f32/go.mod h1:9wM+0iRr9ahx58uY github.com/onsi/gomega v1.27.10 h1:naR28SdDFlqrG6kScpT8VWpu1xWY5nJRCF3XaYyBjhI= github.com/pelletier/go-toml/v2 v2.1.0 h1:FnwAJ4oYMvbT/34k9zzHuZNrhlz48GB3/s6at6/MHO4= github.com/pelletier/go-toml/v2 v2.1.0/go.mod h1:tJU2Z3ZkXwnxa4DPO899bsyIoywizdUvyaeZurnPPDc= +github.com/pelletier/go-toml/v2 v2.2.0 h1:QLgLl2yMN7N+ruc31VynXs1vhMZa7CeHHejIeBAsoHo= +github.com/pelletier/go-toml/v2 v2.2.0/go.mod h1:1t835xjRzz80PqgE6HHgN2JOsmgYu/h4qDAS4n929Rs= github.com/pjbgf/sha1cd v0.3.0 h1:4D5XXmUUBUl/xQ6IjCkEAbqXskkq/4O7LmGn0AqMDs4= github.com/pjbgf/sha1cd v0.3.0/go.mod h1:nZ1rrWOcGJ5uZgEEVL1VUM9iRQiZvWdbZjkKyFzPPsI= github.com/pkg/browser v0.0.0-20210911075715-681adbf594b8 h1:KoWmjvw+nsYOo29YJK9vDA65RGE3NrOnUtO7a+RF9HU= @@ -160,6 +164,7 @@ github.com/spf13/viper v1.18.2/go.mod h1:EKmWIqdnk5lOcmR72yw6hS+8OPYcwD0jteitLMV github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME= github.com/stretchr/objx v0.4.0/go.mod h1:YvHI0jy2hoMjB+UWwv71VJQ9isScKT/TqJzVSSt89Yw= github.com/stretchr/objx v0.5.0/go.mod h1:Yh+to48EsGEfYuaHDzXPcE3xhTkx73EhmCGUpEOglKo= +github.com/stretchr/objx v0.5.2/go.mod h1:FRsXN1f5AsAjCGJKqEizvkpNtU+EGNCLh3NxZ/8L+MA= github.com/stretchr/testify v1.2.2/go.mod h1:a8OnRcib4nhh0OaRAV+Yts87kKdq0PP7pXfy6kDkUVs= github.com/stretchr/testify v1.3.0/go.mod h1:M5WIy9Dh21IEIfnGCwXGc5bZfKNJtfHm1UVUgZn+9EI= github.com/stretchr/testify v1.4.0/go.mod h1:j7eGeouHqKxXV5pUuKE4zz7dFj8WfuZ+81PSLYec5m4= @@ -168,6 +173,8 @@ github.com/stretchr/testify v1.7.1/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/ github.com/stretchr/testify v1.8.0/go.mod h1:yNjHg4UonilssWZ8iaSj1OCr/vHnekPRkoO+kdMU+MU= github.com/stretchr/testify v1.8.4 h1:CcVxjf3Q8PM0mHUKJCdn+eZZtm5yQwehR5yeSVQQcUk= github.com/stretchr/testify v1.8.4/go.mod h1:sz/lmYIOXD/1dqDmKjjqLyZ2RngseejIcXlSw2iwfAo= +github.com/stretchr/testify v1.9.0 h1:HtqpIVDClZ4nwg75+f6Lvsy/wHu+3BoSGCbBAcpTsTg= +github.com/stretchr/testify v1.9.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY= github.com/subosito/gotenv v1.6.0 h1:9NlTDc1FTs4qu0DDq7AEtTPNw6SVm7uBMsUCUjABIf8= github.com/subosito/gotenv v1.6.0/go.mod h1:Dk4QP5c2W3ibzajGcXpNraDfq2IrhjMIvMSWPKKo0FU= github.com/xanzy/ssh-agent v0.3.3 h1:+/15pJfg/RsTxqYcX6fHqOXZwwMP+2VyYWJeWM2qQFM= @@ -186,6 +193,8 @@ golang.org/x/crypto v0.17.0 h1:r8bRNjWL3GshPW3gkd+RpvzWrZAwPS49OmTGZ/uhM4k= golang.org/x/crypto v0.17.0/go.mod h1:gCAAfMLgwOJRpTjQ2zCCt2OcSfYMTeZVSRtQlPC7Nq4= golang.org/x/exp v0.0.0-20230905200255-921286631fa9 h1:GoHiUyI/Tp2nVkLI2mCxVkOjsbSXD66ic0XW0js0R9g= golang.org/x/exp v0.0.0-20230905200255-921286631fa9/go.mod h1:S2oDrQGGwySpoQPVqRShND87VCbxmc6bL1Yd2oYrm6k= +golang.org/x/exp v0.0.0-20240103183307-be819d1f06fc h1:ao2WRsKSzW6KuUY9IWPwWahcHCgR0s52IfwutMfEbdM= +golang.org/x/exp v0.0.0-20240103183307-be819d1f06fc/go.mod h1:iRJReGqOEeBhDZGkGbynYwcHlctCvnjTYIamk7uXpHI= golang.org/x/mod v0.6.0-dev.0.20220419223038-86c51ed26bb4/go.mod h1:jJ57K6gSWd91VN4djpZkiMVwK6gcyfeH4XE8wZrZaV4= golang.org/x/mod v0.8.0/go.mod h1:iBbtSCu2XBx23ZKBPSOrRkjjQPZFPuis4dIYUhu/chs= golang.org/x/mod v0.12.0 h1:rmsUpXtvNzj340zd98LZ4KntptpfRHwpFOHG188oHXc= @@ -199,6 +208,8 @@ golang.org/x/net v0.6.0/go.mod h1:2Tu9+aMcznHK/AK1HMvgo6xiTLG5rD5rZLDS+rp2Bjs= golang.org/x/net v0.8.0/go.mod h1:QVkue5JL9kW//ek3r6jTKnTFis1tRmNAW2P1shuFdJc= golang.org/x/net v0.19.0 h1:zTwKpTd2XuCqf8huc7Fo2iSy+4RHPd10s4KzeTnVr1c= golang.org/x/net v0.19.0/go.mod h1:CfAk/cbD4CthTvqiEl8NpboMuiuOYsAr/7NOjZJtv1U= +golang.org/x/net v0.22.0 h1:9sGLhx7iRIHEiX0oAJ3MRZMUCElJgy7Br1nO+AMN3Tc= +golang.org/x/net v0.22.0/go.mod h1:JKghWKKOSdJwpW2GEx0Ja7fmaKnMsbu+MWVZTokSYmg= golang.org/x/sync v0.0.0-20190423024810-112230192c58/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM= golang.org/x/sync v0.0.0-20220722155255-886fb9371eb4/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM= golang.org/x/sync v0.1.0/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM= @@ -223,6 +234,8 @@ golang.org/x/sys v0.5.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= golang.org/x/sys v0.6.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= golang.org/x/sys v0.15.0 h1:h48lPFYpsTvQJZF4EKyI4aLHaev3CxivZmv7yZig9pc= golang.org/x/sys v0.15.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA= +golang.org/x/sys v0.18.0 h1:DBdB3niSjOA/O0blCZBqDefyWNYveAYMNF1Wum0DYQ4= +golang.org/x/sys v0.18.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA= golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1/go.mod h1:bj7SfCRtBDWHUb9snDiAeCFNEtKQo2Wmx5Cou7ajbmo= golang.org/x/term v0.0.0-20210927222741-03fcf44c2211/go.mod h1:jbD1KX2456YbFQfuXm/mYQcufACuNUgVhRMnK/tPxf8= golang.org/x/term v0.2.0/go.mod h1:TVmDHMZPmdnySmBfhjOoOdhjzdE1h4u1VwSiw2l1Nuc= @@ -230,6 +243,8 @@ golang.org/x/term v0.5.0/go.mod h1:jMB1sMXY+tzblOD4FWmEbocvup2/aLOaQEp7JmGp78k= golang.org/x/term v0.6.0/go.mod h1:m6U89DPEgQRMq3DNkDClhWw02AUbt2daBVO4cn4Hv9U= golang.org/x/term v0.15.0 h1:y/Oo/a/q3IXu26lQgl04j/gjuBDOBlx7X6Om1j2CPW4= golang.org/x/term v0.15.0/go.mod h1:BDl952bC7+uMoWR75FIrCDx79TPU9oHkTZ9yRbYOrX0= +golang.org/x/term v0.18.0 h1:FcHjZXDMxI8mM3nwhX9HlKop4C0YQvCVCdwYl2wOtE8= +golang.org/x/term v0.18.0/go.mod h1:ILwASektA3OnRv7amZ1xhE/KTR+u50pbXfZ03+6Nx58= golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= golang.org/x/text v0.3.3/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ= golang.org/x/text v0.3.6/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ= @@ -245,6 +260,8 @@ golang.org/x/tools v0.1.12/go.mod h1:hNGJHUnrk76NpqgfD5Aqm5Crs+Hm0VOH/i9J2+nxYbc golang.org/x/tools v0.6.0/go.mod h1:Xwgl3UAJ/d3gWutnCtw505GrjyAbvKui8lOU390QaIU= golang.org/x/tools v0.13.0 h1:Iey4qkscZuv0VvIt8E0neZjtPVQFSc870HQ448QgEmQ= golang.org/x/tools v0.13.0/go.mod h1:HvlwmtVNQAhOuCjW7xxvovg8wbNq7LwfXh/k7wXUl58= +golang.org/x/tools v0.19.0 h1:tfGCXNR1OsFG+sVdLAitlpjAvD/I6dHDKnYrpEZUHkw= +golang.org/x/tools v0.19.0/go.mod h1:qoJWxmGSIBmAeriMx19ogtrEPrGtDbPK634QFIcLAhc= golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0= gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0= gopkg.in/check.v1 v1.0.0-20190902080502-41f04d3bba15/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0= diff --git a/internal/config/config.go b/internal/config/config.go index 355abbbc..f5797b6e 100644 --- a/internal/config/config.go +++ b/internal/config/config.go @@ -41,6 +41,10 @@ type ProjectConfig struct { Pipeline string `yaml:"pipeline"` } +type LocalConfig struct { + Pipeline string `yaml:"pipeline"` +} + type ViperConfig interface { Set(string, interface{}) GetStringMap(string) map[string]interface{} @@ -150,3 +154,34 @@ func writePipelineToBuildkiteYAML(projectConfig *ProjectConfig) (*ProjectConfig, return projectConfig, nil } + +// Local config .bk.yaml or .bk.yml may or may not exist. Load it if it does. +func (config *LocalConfig) Read() error { + + var configFile string + if _, err := os.Stat(".bk.yaml"); err == nil { + configFile = ".bk.yaml" + } else if _, err := os.Stat(".bk.yml"); err == nil { + configFile = ".bk.yml" + } + + // If a configuration file is found, try to read and parse it + if configFile != "" { + yamlFile, err := os.ReadFile(configFile) + if err != nil { + return err + } + + err = yaml.Unmarshal(yamlFile, config) + if err != nil { + return err + } + + // Check if the "pipeline" key is already set + if config.Pipeline != "" { + return nil // Pipeline is already defined + } + + } + return nil +} diff --git a/internal/pipelines/resolverfromconfig.go b/internal/pipelines/resolverfromconfig.go new file mode 100644 index 00000000..80063b39 --- /dev/null +++ b/internal/pipelines/resolverfromconfig.go @@ -0,0 +1,25 @@ +package pipelines + +import ( + "fmt" + "strings" + + "github.com/buildkite/cli/v3/pkg/cmd/factory" +) + +func ResolveFromConfig(f *factory.Factory) ([]string, error) { + + var localPipelines []string + // check if there is a local config file + err := f.LocalConfig.Read() + if err != nil { + fmt.Printf("Error reading local config: %s", err) + return nil, err + } + // if there is a pipeline defined in the local config, return it + if len(f.LocalConfig.Pipeline) > 0 { + //assume pipelines are comma separated - final format TBD + localPipelines = strings.Split(f.LocalConfig.Pipeline, ",") + } + return localPipelines, nil +} diff --git a/internal/pipelines/resolverfromconfig_test.go b/internal/pipelines/resolverfromconfig_test.go new file mode 100644 index 00000000..3ff27bbe --- /dev/null +++ b/internal/pipelines/resolverfromconfig_test.go @@ -0,0 +1,62 @@ +package pipelines + +import ( + "os" + "testing" + + "github.com/buildkite/cli/v3/internal/config" + "github.com/buildkite/cli/v3/pkg/cmd/factory" + "gopkg.in/yaml.v3" +) + +func TestResolvePipelineFromConfig(t *testing.T) { + + t.Run("local config does not exist", func(t *testing.T) { + f := factory.Factory{ + LocalConfig: &config.LocalConfig{}, + } + + pipelines, _ := ResolveFromConfig(&f) + if len(pipelines) > 0 { + t.Errorf("Expected empty string, got %d pipelines: %v", len(pipelines), pipelines) + } + }) + + t.Run("local config exists but no pipeline defined", func(t *testing.T) { + f := factory.Factory{ + LocalConfig: &config.LocalConfig{}, + } + + f.LocalConfig.Pipeline = "" + pipelines, _ := ResolveFromConfig(&f) + if len(pipelines) > 0 { + t.Errorf("Expected empty string, got %d pipelines: %v", len(pipelines), pipelines) + } + + }) + + t.Run("local config exists and a pipeline is defined", func(t *testing.T) { + f := factory.Factory{ + LocalConfig: &config.LocalConfig{}, + } + + newLocalConfig := make(map[string]interface{}) + newLocalConfig["pipeline"] = "new-sample-pipeline" + newData, err := yaml.Marshal(&newLocalConfig) + if err != nil { + t.Errorf("Error: %s", err) + } + + err = os.WriteFile(".bk.yaml", newData, 0o644) + if err != nil { + t.Errorf("Error: %s", err) + } + + pipelines, _ := ResolveFromConfig(&f) + if len(pipelines) > 0 && pipelines[0] != newLocalConfig["pipeline"] { + t.Errorf("Expected %s, got %s", newLocalConfig["pipeline"], pipelines[0]) + } + os.Remove(".bk.yaml") + }) + +} diff --git a/internal/pipelines/resolver.go b/internal/pipelines/resolverfrompath.go similarity index 99% rename from internal/pipelines/resolver.go rename to internal/pipelines/resolverfrompath.go index 3ad57ad1..be395fd6 100644 --- a/internal/pipelines/resolver.go +++ b/internal/pipelines/resolverfrompath.go @@ -4,11 +4,11 @@ import ( "strings" "github.com/buildkite/go-buildkite/v3/buildkite" - "github.com/go-git/go-git/v5" ) func ResolveFromPath(path string, org string, client *buildkite.Client) ([]string, error) { + repos, err := getRepoURLs(path) if err != nil { return nil, err @@ -17,6 +17,7 @@ func ResolveFromPath(path string, org string, client *buildkite.Client) ([]strin } func filterPipelines(repoURLs []string, org string, client *buildkite.Client) ([]string, error) { + var currentPipelines []string page := 1 per_page := 30 diff --git a/internal/pipelines/resolver_test.go b/internal/pipelines/resolverfrompath_test.go similarity index 98% rename from internal/pipelines/resolver_test.go rename to internal/pipelines/resolverfrompath_test.go index 9cb7bab1..0121d64c 100644 --- a/internal/pipelines/resolver_test.go +++ b/internal/pipelines/resolverfrompath_test.go @@ -8,7 +8,7 @@ import ( "github.com/h2non/gock" ) -func TestResolvePipelines(t *testing.T) { +func TestResolvePipelinesFromPath(t *testing.T) { t.Parallel() t.Run("path has no repo URL", func(t *testing.T) { diff --git a/pkg/cmd/factory/factory.go b/pkg/cmd/factory/factory.go index 3cf0b91a..6cf69ef9 100644 --- a/pkg/cmd/factory/factory.go +++ b/pkg/cmd/factory/factory.go @@ -14,6 +14,7 @@ import ( type Factory struct { Config *config.Config ProjectConfig *config.ProjectConfig + LocalConfig *config.LocalConfig HttpClient *http.Client RestAPIClient *buildkite.Client Version string @@ -23,6 +24,7 @@ func New(version string) *Factory { factoryConfig := loadFromViper() client := httpClient(version, factoryConfig) projectConfig, err := config.LoadProjectConfig() + if err != nil { fmt.Printf("Error loading project config: %s", err) } @@ -33,6 +35,7 @@ func New(version string) *Factory { RestAPIClient: buildkite.NewClient(client), Version: version, ProjectConfig: projectConfig, + LocalConfig: &config.LocalConfig{}, } }