Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue with test cleanup if previous cleanup fails #121

Open
natalieparellano opened this issue May 19, 2021 · 0 comments
Open

Continue with test cleanup if previous cleanup fails #121

natalieparellano opened this issue May 19, 2021 · 0 comments

Comments

@natalieparellano
Copy link
Member

In our tests, we have some cleanup steps that are wrapped in an h.AssertNil. If the cleanup fails, we'll halt execution and not do other cleanup steps.

If any cleanup steps fail, we should set the test outcome to failed, but we should continue with other cleanup. See conversation here: #114 (comment) for how pack accomplishes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant