From 55cfde33a629f126b7de3b07b4e84fea383f0d81 Mon Sep 17 00:00:00 2001 From: Ed Morley <501702+edmorley@users.noreply.github.com> Date: Thu, 11 Apr 2024 17:39:49 +0100 Subject: [PATCH] RFC 0128: Use correct `[[targets.distros]]` schema Updates RFC 0128 to use the correct `[[targets.distros]]` schema as defined already in the spec: https://github.com/buildpacks/spec/blob/main/buildpack.md#buildpacktoml-toml I've not added an `## Amended` section, since: 1. The RFC has only just merged (this is effectively a review comment that missed the merge by a day) 2. The parts of the RFC being fixed are existing concepts already in the spec, rather than design decisions relating to the purpose of the RFC itself. Fixes: https://github.com/buildpacks/rfcs/pull/295#discussion_r1559614121 Signed-off-by: Ed Morley <501702+edmorley@users.noreply.github.com> --- text/0128-multiarch-builders-and-package.md | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/text/0128-multiarch-builders-and-package.md b/text/0128-multiarch-builders-and-package.md index 3d3844985..e36d1d2bc 100644 --- a/text/0128-multiarch-builders-and-package.md +++ b/text/0128-multiarch-builders-and-package.md @@ -95,9 +95,9 @@ arch = "arm64" os = "windows" arch = "amd64" -[[targets.distributions]] +[[targets.distros]] name = "windows" -versions = ["10.0.20348.1970"] +version = "10.0.20348.1970" # Stacks (deprecated) the buildpack will work with [[stacks]] @@ -286,9 +286,9 @@ variant = "" # optional path = "" -[[targets.distributions]] +[[targets.distros]] name = "" -versions = [""] +version = "" ``` - When `more than 1 target is defined` - When `--publish` is specified @@ -681,9 +681,9 @@ arch = "arm64" os = "windows" arch = "amd64" -[[targets.distributions]] +[[targets.distros]] name = "windows" -versions = ["10.0.20348.1970"] +version = "10.0.20348.1970" # Stacks (deprecated) the buildpack will work with [[stacks]] @@ -763,9 +763,9 @@ os = "" arch = "" variant = "" -[[targets.distributions]] +[[targets.distros]] name = "" -versions = [""] +version = "" [[dependencies]] uri = "" @@ -843,9 +843,9 @@ image = "" os = "" arch = "" variant = "" -[[targets.distributions]] +[[targets.distros]] name = "" -versions = [""] +version = "" ``` - Add a new `--target` optional flag with format `[os][/arch][/variant]:[name@version]` to create a builder for a particular target, this will help end-users to specify the platform for which they want to create single OCI artifact.