do not delete mlock files after update

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

Author: butonic

changelog/unreleased/no-delete-lock.md

@@ -0,0 +1,6 @@
+Bugfix: Do not delete mlock files
+
+To prevent stale NFS file handles we no longer delete empty mlock files after updating the metadata.
+
+https://github.com/cs3org/reva/pull/4936
+https://github.com/cs3org/reva/pull/4924

pkg/storage/utils/decomposedfs/upload/store.go

@@ -31,6 +31,11 @@ import (
 	"time"
 
 	provider "github.com/cs3org/go-cs3apis/cs3/storage/provider/v1beta1"
+	"github.com/google/uuid"
+	"github.com/pkg/errors"
+	"github.com/rogpeppe/go-internal/lockedfile"
+	tusd "github.com/tus/tusd/v2/pkg/handler"
+
 	"github.com/cs3org/reva/v2/pkg/appctx"
 	"github.com/cs3org/reva/v2/pkg/errtypes"
 	"github.com/cs3org/reva/v2/pkg/events"
@@ -41,10 +46,6 @@ import (
 	"github.com/cs3org/reva/v2/pkg/storage/utils/decomposedfs/node"
 	"github.com/cs3org/reva/v2/pkg/storage/utils/decomposedfs/options"
 	"github.com/cs3org/reva/v2/pkg/storage/utils/decomposedfs/usermapper"
-	"github.com/google/uuid"
-	"github.com/pkg/errors"
-	"github.com/rogpeppe/go-internal/lockedfile"
-	tusd "github.com/tus/tusd/v2/pkg/handler"
 )
 
 var _idRegexp = regexp.MustCompile(".*/([^/]+).info")
@@ -312,11 +313,8 @@ func (store OcisStore) updateExistingNode(ctx context.Context, session *OcisSess
 	}
 
 	unlock := func() error {
-		err := f.Close()
-		if err != nil {
-			return err
-		}
-		return os.Remove(store.lu.MetadataBackend().LockfilePath(targetPath))
+		// NOTE: to prevent stale NFS file handles do not remove lock file!
+		return f.Close()
 	}
 
 	old, _ := node.ReadNode(ctx, store.lu, spaceID, n.ID, false, nil, false)