Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kyber1024: ref polyvec.rs mismatched types #3

Open
pinkforest opened this issue Feb 29, 2024 · 0 comments
Open

kyber1024: ref polyvec.rs mismatched types #3

pinkforest opened this issue Feb 29, 2024 · 0 comments

Comments

@pinkforest
Copy link

pinkforest commented Feb 29, 2024

Got this in CI when doing feature testing

$ cargo build --release --target thumbv7em-none-eabi --no-default-features --features kyber1024

   Compiling safe_pqc_kyber v0.6.2 (/home/foobar/code/safe-kyber)
warning: dropping unsupported crate type `cdylib` for target `thumbv7em-none-eabi`

error[E0308]: mismatched types
  --> src/reference/polyvec.rs:39:31
   |
39 |           let mut tmp : u64 = ((t[k] as u32) << 11) + KYBER_Q as u32/2;
   |                         ---   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `u64`, found `u32`
   |                         |
   |                         expected due to this
   |
help: you can convert a `u32` to a `u64`
   |
39 |           let mut tmp : u64 = (((t[k] as u32) << 11) + KYBER_Q as u32/2).into();
   |                               +                                        ++++++++

For more information about this error, try `rustc --explain E0308`.
warning: `safe_pqc_kyber` (lib) generated 1 warning
error: could not compile `safe_pqc_kyber` (lib) due to 1 previous error; 1 warning emitted
[foobar@localhost safe-kyber]$ 
pinkforest added a commit to pinkforest/safe-kyber that referenced this issue Feb 29, 2024
bwesterb pushed a commit that referenced this issue Jun 20, 2024
Fix no_std for Cargo.toml

ci: Temp check own branch

Ignore kyber1024 for now - pending issue #3

Revert "ci: Temp check own branch"

This reverts commit 993292e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant