Fix Random Idea Button doesn't fetch new idea when in "/random" already #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #39 by updating Layout.js to do a http redirect instead of changing location. This causes the retrieveRandomIdea function in random.js to run again and get a different idea. Update Layout.js
bykof
reviewed
Nov 17, 2024
| @@ -159,7 +159,7 @@ const Layout = ({ children }) => { | |||
| <div className="navbar-end"> | |||
| <div className="navbar-item"> | |||
| <div className="buttons"> | |||
| <Link href="/random" className="button is-default"> | |||
| <Link className="button is-default" onClick={()=>window.location.replace("/random")}> | |||
There was a problem hiding this comment.
this is somehow strange, because a href does actually the same thing... maybe it's because this is a next/link ...
Then there are probably some settings for this link, to enforce a reload
|
I fixed this problem in the newest commit of what-to-code :) thank you for contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #39 by updating Layout.js to do a http redirect instead of changing location. This causes the retrieveRandomIdea function in random.js to run again and get a different idea.