Skip to content

Commit b3c6973

Browse files
author
Nikolay Kucheriaviy
authored
Merge pull request #3 from Ne1c/dev
Release 1.2.1
2 parents 3e2ce53 + 18bcba9 commit b3c6973

File tree

4 files changed

+13
-17
lines changed

4 files changed

+13
-17
lines changed

rainbowmvp/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ android {
77
defaultConfig {
88
minSdkVersion 9
99
targetSdkVersion 24
10-
versionCode 3
11-
versionName "1.2"
10+
versionCode 4
11+
versionName "1.2.1"
1212
}
1313
buildTypes {
1414
release {

rainbowmvp/src/main/java/com/ne1c/rainbowmvp/ViewState.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@
2424
* FINISH - use in end of work any operation
2525
* SUCCESS - use for show result of any operation
2626
* ERROR - use for show error of any operation
27-
* EMPTY - use for default state if not necessary show any information
27+
* NOTHING - use for default state if not necessary show any information
2828
*/
2929
public enum ViewState {
30-
START, IN_PROGRESS, FINISH, SUCCESS, ERROR, EMPTY
30+
START, IN_PROGRESS, FINISH, SUCCESS, ERROR, NOTHING
3131
}

rainbowmvp/src/main/java/com/ne1c/rainbowmvp/base/BasePresenter.java

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,19 @@
1616

1717
package com.ne1c.rainbowmvp.base;
1818

19+
import android.support.annotation.NonNull;
20+
import android.support.annotation.Nullable;
21+
1922
import com.ne1c.rainbowmvp.ViewState;
2023
import com.ne1c.rainbowmvp.ViewStateListener;
2124

2225
public abstract class BasePresenter<V> {
2326
private V mView;
2427

25-
private ViewState mLastState = ViewState.EMPTY;
28+
private ViewState mLastState = ViewState.NOTHING;
2629
private ViewStateListener mViewStateListener;
2730

28-
public void bindView(V view) {
31+
public void bindView(@NonNull V view) {
2932
mView = view;
3033

3134
if (mViewStateListener != null) {
@@ -41,22 +44,15 @@ public void onDestroy() {
4144
removeViewStateListener();
4245
}
4346

47+
@Nullable
4448
public V getView() {
4549
return mView;
4650
}
4751

4852
public void setViewState(ViewState state) {
4953
mLastState = state;
5054

51-
if (mViewStateListener != null) {
52-
mViewStateListener.stateChanged(state);
53-
}
54-
}
55-
56-
public void setViewState(ViewState state, boolean callListener) {
57-
mLastState = state;
58-
59-
if (callListener && mViewStateListener != null) {
55+
if (mViewStateListener != null && mView != null) {
6056
mViewStateListener.stateChanged(state);
6157
}
6258
}

sample/src/main/java/com/ne1c/rainbowmvpexample/presenter/MainPresenter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ public void call(ArrayList<RepoModel> repoModels) {
6868
if (getView() != null) {
6969
getView().showRepos(repoModels);
7070
getView().hideProgress();
71-
setViewState(ViewState.EMPTY);
71+
setViewState(ViewState.NOTHING);
7272
}
7373
}
7474
}, new Action1<Throwable>() {
@@ -80,7 +80,7 @@ public void call(Throwable throwable) {
8080
getView().showError(R.string.something_happened);
8181
getView().hideProgress();
8282

83-
setViewState(ViewState.EMPTY);
83+
setViewState(ViewState.NOTHING);
8484
}
8585
}
8686
});

0 commit comments

Comments
 (0)