Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need a better description of the model run times #2

Open
gregmacfarlane opened this issue Oct 9, 2024 · 3 comments
Open

We need a better description of the model run times #2

gregmacfarlane opened this issue Oct 9, 2024 · 3 comments
Assignees
Milestone

Comments

@gregmacfarlane
Copy link
Contributor

Reviewer 1 says:

I was quite surprised that the demand components of the trip based model took 10 hours, that seems very long. However, the flow chart shows that an assignment is part of each iteration which is somewhat more reasonable, but still quite long. But, this is not an even comparison with the ActivitySim that does not include any network initialization, building, or skimming steps. A better comparison could be a component by component or a comparison of the number of computations.

I think I agree with this criticism. Can we get a breakdown of the WFRC model run time by:

  • How long does skimming / assignment take?
  • How long does one loop of trip generation / distribution / and mode choice take?

This is of course made more difficult by the fact that the WFRC model does mode choice AFTER assignment has converged. But can we get a log and build a schedule?

Would be nice to get an apples-to-apples (one run of ActivitySim, one run of the demand components of the WFRC model)

@gregmacfarlane
Copy link
Contributor Author

ActivitySim log is here: https://byu.app.box.com/file/1292154340611
WFRC log is here: https://byu.app.box.com/file/1405569820101

@gregmacfarlane
Copy link
Contributor Author

Perhaps we can build a figure that has better details of the execution at each step, removing feedback loops.

@gregmacfarlane
Copy link
Contributor Author

Actually, let's use the activitySim log at C:\projects\wfrc_asim_scenario\activitysim\output\base_2019_mp_3 on Beast

@gregmacfarlane gregmacfarlane self-assigned this Oct 9, 2024
@gregmacfarlane gregmacfarlane added this to the ICTD milestone Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant