Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OrdinalChoicesDistribution for Kubeflow/Katib. #153

Open
c-bata opened this issue Aug 8, 2020 · 4 comments
Open

Support OrdinalChoicesDistribution for Kubeflow/Katib. #153

c-bata opened this issue Aug 8, 2020 · 4 comments
Labels
effort low enhancement New feature or request

Comments

@c-bata
Copy link
Owner

c-bata commented Aug 8, 2020

See the following code comment of Katib.

// Use categorical distribution instead of goptuna.DiscreteUniformDistribution
// because goptuna.DiscreteUniformDistributions needs to declare the parameter
// space with minimum value, maximum value and interval.
choices := p.GetFeasibleSpace().GetList()
searchSpace[p.Name] = goptuna.CategoricalDistribution{
	Choices: choices,
}

https://github.com/kubeflow/katib/blob/2c4ad152cd5d534c86923a23e7350185d32b5538/pkg/suggestion/v1beta1/goptuna/converter.go#L146-L154

@c-bata
Copy link
Owner Author

c-bata commented Aug 8, 2020

Uber/bayesmark

# Treat ordinal identically to categorical for now
SPACE_DICT = {"real": Real, "int": Integer, "bool": Boolean, "cat": Categorical, "ordinal": Categorical}

https://github.com/uber/bayesmark/blob/38d8b3c6fae5799c4a8ac6ebf1cf91ffae3daf74/bayesmark/space.py#L668-L669

@gaocegege
Copy link

Awesome, let us know if you need any help!

@c-bata
Copy link
Owner Author

c-bata commented Aug 8, 2020

Thank you!

@c-bata c-bata added effort medium enhancement New feature or request labels Aug 19, 2020
@c-bata
Copy link
Owner Author

c-bata commented Aug 29, 2020

memo: This feature is related to optuna/optuna#1736.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort low enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants