feat: change to generics

Remove existential type and also removes need for box

Author: c-git

src/native.rs

@@ -4,10 +4,10 @@
 compile_error!("Must chose a native runtime by enabling a feature flag. Right now only tokio is supported. If you have a different runtime that you want please create an issue on github.");
 
 #[cfg(feature = "native-tokio")]
-pub(crate) fn fetch(
-    request: reqwest::RequestBuilder,
-    on_done: impl 'static + Send + FnOnce(Result<reqwest::Response, reqwest::Error>),
-) {
+pub fn fetch<F>(request: reqwest::RequestBuilder, on_done: F)
+where
+    F: 'static + Send + FnOnce(Result<reqwest::Response, reqwest::Error>),
+{
     tokio::spawn(async move {
         let result = request.send().await;
         on_done(result)

src/wasm.rs

@@ -1,11 +1,9 @@
 //! Stores the code specific to wasm compilations
 
-use reqwest::RequestBuilder;
-
-pub(crate) fn fetch(
-    request: RequestBuilder,
-    on_done: impl 'static + Send + FnOnce(Result<reqwest::Response, reqwest::Error>),
-) {
+pub fn fetch<F>(request: reqwest::RequestBuilder, on_done: F)
+where
+    F: 'static + Send + FnOnce(reqwest::Result<reqwest::Response>),
+{
     wasm_bindgen_futures::spawn_local(async move {
         let result = request.send().await;
         on_done(result)

src/wrappers.rs

@@ -1,8 +1,6 @@
 //! Stores the wrapper functions that can be called from either native or wasm
 //! code
 
-use reqwest::{Error, RequestBuilder, Response};
-
 /// Performs a HTTP requests and calls the given callback when done. NB: Needs
 /// to use a callback to prevent blocking on the thread that initiates the
 /// fetch. Note: Instead of calling get like in the example you can use post,
@@ -34,17 +32,15 @@ use reqwest::{Error, RequestBuilder, Response};
 /// # #[cfg(target_arch = "wasm32")]
 /// # fn main(){}
 /// ```
-pub fn fetch(
-    request: RequestBuilder,
-    on_done: impl 'static + Send + FnOnce(Result<Response, Error>),
-) {
+pub fn fetch<F>(request: reqwest::RequestBuilder, on_done: F)
+where
+    F: 'static + Send + FnOnce(reqwest::Result<reqwest::Response>),
+{
     #[cfg(not(target_arch = "wasm32"))]
-    crate::native::fetch(request, Box::new(on_done));
+    crate::native::fetch(request, on_done);
 
     #[cfg(target_arch = "wasm32")]
-    crate::wasm::fetch(request, Box::new(on_done));
+    crate::wasm::fetch(request, on_done);
 }
 
-//  TODO 3: Change to generics for `on_done`
-
 // TODO 3: Test link in documentation after pushing to main