Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dippindots/svg2pdf.js
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: cBioPortal/svg2pdf.js
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Able to merge. These branches can be automatically merged.
  • 2 commits
  • 6 files changed
  • 2 contributors

Commits on Apr 1, 2023

  1. Copy the full SHA
    08b6cfc View commit details

Commits on Apr 26, 2023

  1. Merge pull request #1 from jfkonecn/hotfix

    now can handle null d attribute
    dippindots authored Apr 26, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    5a935ad View commit details
Showing with 3,907 additions and 1,372 deletions.
  1. +1,364 −1,365 dist/svg2pdf.js
  2. +3 −4 dist/svg2pdf.min.js
  3. +3 −3 src/svg2pdf.js
  4. BIN tests/cbioportal-overlap/reference.pdf
  5. +2,536 −0 tests/cbioportal-overlap/spec.svg
  6. +1 −0 tests/runTests.js
2,729 changes: 1,364 additions & 1,365 deletions dist/svg2pdf.js

Large diffs are not rendered by default.

7 changes: 3 additions & 4 deletions dist/svg2pdf.min.js

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions src/svg2pdf.js
Original file line number Diff line number Diff line change
@@ -52,7 +52,7 @@ SOFTWARE.

// pathSegList is marked deprecated in chrome, so parse the d attribute manually if necessary
var getPathSegList = function (node) {
var d = node.getAttribute("d");
var d = node.getAttribute("d") || "";

// Replace arcs before path segment list is handled
if (SvgPath) {
@@ -61,7 +61,7 @@ SOFTWARE.
}

var pathSegList = node.pathSegList;

if (pathSegList) {
return pathSegList;
}
@@ -2260,7 +2260,7 @@ SOFTWARE.
});
} else if (typeof module !== "undefined" && module.exports) {
RGBColor = require("./rgbcolor.js");
SvgPath = require("SvgPath");
SvgPath = require("svgpath");
FontFamily = require("font-family");
cssEsc = require("cssesc");
module.exports = svg2pdf;
Binary file added tests/cbioportal-overlap/reference.pdf
Binary file not shown.
2,536 changes: 2,536 additions & 0 deletions tests/cbioportal-overlap/spec.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions tests/runTests.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
const debug = false;

const tests = [
"cbioportal-overlap",
"clippath",
"complete-bpmn",
"complete-computer-network",