Skip to content

Conversation

@jbreue16
Copy link
Contributor

@jbreue16 jbreue16 commented Apr 19, 2024

We have started adding parameter dependencies (both state and paramter dependece) in #120

There are still desirable dependencies that are not implemented yet.
Furthermore, we decided to change the return logic of the parameter dependencies to return the values itself, not a modifying prefactor

  • expand tests
  • DG units parameter dependencies as in FV units
  • Film diffusion in GRM (check what weve done there back then and bug fix)
  • Change return logic of parameter dependencies so that the value itself is returned, not a factor (done but double check)
  • Register parameters s.t. they can be read when reading all parameters
  • Add flag to return parameter trajectory over time in output.

jbreue16 and others added 2 commits May 8, 2024 15:45
Logic changed such that the parameter value itself is returned, instead of a modifying factor

Co-authored-by: schmoelder <j.schmoelder@fz-juelich.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants