Skip to content

Pass recoverable error to IDAS when residual contains NaN #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jbreue16 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Pass recoverable error to IDAS when residual contains NaN #490

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
27eceab
Pass recoverable error to IDAS when residual contains NaN
jbreue16 Sep 26, 2025
2bb8f1f
fixup!
jbreue16 Sep 26, 2025
970f8b1
fixup! add break
jbreue16 Sep 26, 2025
170041e
fixup!
jbreue16 Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/libcadet/model/ModelSystemImpl-Residual.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,6 +532,17 @@ int ModelSystem::residual(const SimulationTime& simTime, const ConstSimulationSt
}

_errorIndicator[i] = m->residual(simTime, applyOffset(simState, offset), res + offset, _threadLocalStorage);

for (int j = 0; j < _dofs[i]; j++)
{
if (std::isnan(res[offset + j]))
{
LOG(Warning) << "Residual has NAN value in unit " << i << " (at least) at index " << j;
_errorIndicator[i] = 1; // recoverable error
break;
}
}

} CADET_PARFOR_END;

// Handle connections
Expand Down Expand Up @@ -567,6 +578,16 @@ int ModelSystem::residualWithJacobian(const SimulationTime& simTime, const Const
_errorIndicator[i] = m->residualWithJacobian(simTime, applyOffset(simState, offset),
res + offset, applyOffset(adJac, offset), _threadLocalStorage);

for (int j = 0; j < _dofs[i]; j++)
{
if (std::isnan(res[offset + j]))
{
LOG(Warning) << "Residual has NAN value in unit " << i << " (at least) at index " << j;
_errorIndicator[i] = 1; // recoverable error
break;
}
}

} CADET_PARFOR_END;

// Handle connections
Expand Down
Loading