Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Minor Fixes #2

Open
ramazansancar opened this issue Sep 25, 2024 · 0 comments
Open

[Fix] Minor Fixes #2

ramazansancar opened this issue Sep 25, 2024 · 0 comments

Comments

@ramazansancar
Copy link

ramazansancar commented Sep 25, 2024

Apart from these, the project is still working even though it was last updated 4 years ago. Good job.

image

image

  • It needs to work depending on requestURL .env. In order to work without interfering with the code, .env needs to be updated and it needs to work.
REACT_APP_SERVER_API_URL=http://localhost:3003

https://github.com/cahitihac/kap-notifier/blob/master/src/App.js#L79-L82

  • react-scripts dependencies must be version ^5.0.1 to work on Node 20.x and npm 10.x.
{
  "name": "kap-notifier",
  "version": "0.1.0",
  "private": true,
  "dependencies": {
    "axios": "^0.19.2",
    "cors": "^2.8.5",
    "express": "^4.17.1",
    "react": "^16.13.1",
    "react-dom": "^16.13.1",
    "react-scripts": "^5.0.1" // Upgraded
  },
  "scripts": {
    "start": "react-scripts start",
    "build": "react-scripts build",
    "test": "react-scripts test",
    "server": "node ./server/index.js",
    "eject": "react-scripts eject"
  },
  "eslintConfig": {
    "extends": "react-app"
  },
  "browserslist": {
    "production": [
      ">0.2%",
      "not dead",
      "not op_mini all"
    ],
    "development": [
      "last 1 chrome version",
      "last 1 firefox version",
      "last 1 safari version"
    ]
  },
  "engines": {
    "node": "20.x", // Upgraded
    "npm": "10.x" // Upgraded
  }
}
ramazansancar added a commit to ramazansancar/cahitihac_kap-notifier that referenced this issue Sep 25, 2024
feat: disclosureIndex added.
upg: Dependencies upgraded.
upd: switch yarn to pnpm compiler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant