Facade for every opts.logger method

Author: caiogondim

src/base.js

@@ -13,6 +13,7 @@ module.exports = function () {
     this.opts = Logdown._normalizeOpts(prefix, opts)
     this.state = Logdown._getInitialState(this.opts)
 
+    Logdown._decorateLoggerMethods(this)
     Logdown._instances.push(this)
 
     return this
@@ -86,26 +87,23 @@ module.exports = function () {
     return isEnabled
   }
 
-  //
-  // Instance
-  //
-
-  var methods = ['debug', 'log', 'info', 'warn', 'error']
-  methods.forEach(function (method) {
-    Logdown.prototype[method] = function () {
-      if (!this.state.isEnabled) {
-        return
-      }
+  Logdown._decorateLoggerMethods = function (instance) {
+    Object.keys(instance.opts.logger).forEach(function (method) {
+      instance[method] = function () {
+        if (!this.state.isEnabled) {
+          return
+        }
 
-      var args = toArray(arguments)
-      var preparedOutput = this._prepareOutput(args, method)
+        var args = toArray(arguments)
+        var preparedOutput = this._prepareOutput(args, method)
 
-      ;(this.opts.logger[method] || this.opts.logger.log).apply(
-        this.opts.logger,
-        preparedOutput
-      )
-    }
-  }, this)
+        ;(this.opts.logger[method] || this.opts.logger.log).apply(
+          this.opts.logger,
+          preparedOutput
+        )
+      }
+    })
+  }
 
   return Logdown
 }

test/browser/logging-methods.test.js

@@ -11,8 +11,7 @@ globalObject.localStorage = localStorage
 const logdown = require('../../src/browser')
 const markdown = require('../../src/markdown/browser')
 
-const methods = ['debug', 'log', 'info', 'warn', 'error']
-methods.forEach((method) => {
+Object.keys(console).forEach((method) => {
   describe('logdown.' + method, () => {
     beforeEach(() => {
       console[method] = console[method] || console.log
@@ -83,5 +82,14 @@ methods.forEach((method) => {
 
       expect(console[method]).not.toHaveBeenCalled()
     })
+
+    it('has a facade for every method on opts.logger', () => {
+      const consoleKeys = Object.keys(console)
+      const foo = logdown('foo', { logger: console })
+
+      consoleKeys.forEach(consoleMethod => {
+        expect(typeof foo[consoleMethod]).toBe('function')
+      })
+    })
   })
 })

test/common/logging-methods.test.js

@@ -0,0 +1,33 @@
+/* eslint-env jest */
+
+const logdown = require('../../src/node')
+
+//
+// Tests
+//
+
+Object.keys(console).forEach(method => {
+  describe(`logdown.${method}`, () => {
+    beforeEach(() => {
+      console[method] = console[method] || console.log
+      console[method] = jest.fn()
+
+      logdown._instances = []
+      process.env.NODE_DEBUG = 'foo'
+      logdown._setPrefixRegExps()
+    })
+
+    afterEach(() => {
+      console[method].mockClear()
+    })
+
+    it('has a facade for every method on opts.logger', () => {
+      const consoleKeys = Object.keys(console)
+      const foo = logdown('foo', { logger: console })
+
+      consoleKeys.forEach(consoleMethod => {
+        expect(typeof foo[consoleMethod]).toBe('function')
+      })
+    })
+  })
+})

test/node/logging-methods.test.js

@@ -7,7 +7,7 @@ const markdown = require('../../src/markdown/node')
 // Tests
 //
 
-;['debug', 'log', 'info', 'warn', 'error'].forEach(method => {
+Object.keys(console).forEach(method => {
   describe(`logdown.${method}`, () => {
     beforeEach(() => {
       console[method] = console[method] || console.log
@@ -104,5 +104,14 @@ const markdown = require('../../src/markdown/node')
 
       expect(console[method]).not.toHaveBeenCalled()
     })
+
+    it('has a facade for every method on opts.logger', () => {
+      const consoleKeys = Object.keys(console)
+      const foo = logdown('foo', { logger: console })
+
+      consoleKeys.forEach(consoleMethod => {
+        expect(typeof foo[consoleMethod]).toBe('function')
+      })
+    })
   })
 })