Skip to content

Commit 9af6778

Browse files
committed
(build) Fix criteria for signing binaries
As part of the refactoring effort, we broke the criteria used for deciding if binaries should be signed. As a result, signing of binaries was being skipped when running on a tagged build.
1 parent f06bfed commit 9af6778

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

recipe.cake

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -265,18 +265,18 @@ Task("Run-Bakery-Integration-Tests")
265265
}
266266
});
267267

268+
var shouldDeployBakery = (!BuildParameters.IsLocalBuild || BuildParameters.ForceContinuousIntegration) &&
269+
BuildParameters.IsTagged &&
270+
BuildParameters.PreferredBuildAgentOperatingSystem == BuildParameters.BuildAgentOperatingSystem &&
271+
BuildParameters.PreferredBuildProviderType == BuildParameters.BuildProvider.Type;
268272
Task("Sign-Binaries")
269273
.IsDependentOn("Package")
270274
.IsDependeeOf("Upload-AppVeyor-Artifacts-Zip")
271275
.IsDependeeOf("Publish-PreRelease-Packages")
272276
.IsDependeeOf("Publish-Release-Packages")
273277
.IsDependeeOf("Publish-GitHub-Release-Zip")
274278
.IsDependeeOf("Publish-GitHub-Release")
275-
.WithCriteria(() => string.Equals(EnvironmentVariable("SIGNING_TEST"), "true", StringComparison.OrdinalIgnoreCase))
276-
.WithCriteria(() => !BuildParameters.IsLocalBuild || BuildParameters.ForceContinuousIntegration, "Skipping because this is a local build, and force isn't being applied")
277-
.WithCriteria(() => BuildParameters.IsTagged, "Skipping because current commit is not tagged")
278-
.WithCriteria(() => BuildParameters.PreferredBuildAgentOperatingSystem == BuildParameters.BuildAgentOperatingSystem, "Not running on preferred build agent operating system")
279-
.WithCriteria(() => BuildParameters.PreferredBuildProviderType == BuildParameters.BuildProvider.Type, "Not running on preferred build provider type")
279+
.WithCriteria(() => shouldDeployBakery || string.Equals(EnvironmentVariable("SIGNING_TEST"), "true", StringComparison.OrdinalIgnoreCase))
280280
.Does(() =>
281281
{
282282
// Get the secret.

0 commit comments

Comments
 (0)