Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete Cake.DotNetTool.Module.yml #3127

Open
cake-contrib-bot opened this issue Dec 24, 2024 · 3 comments · May be fixed by #3128
Open

Delete Cake.DotNetTool.Module.yml #3127

cake-contrib-bot opened this issue Dec 24, 2024 · 3 comments · May be fixed by #3128

Comments

@cake-contrib-bot
Copy link
Contributor

The Cake.AddinDiscoverer tool has discovered that a YAML file exists on the Cake web site for a nuget package that is no longer available on NuGet.org.

Cake.DotNetTool.Module.yml.yaml must be deleted.
cake-contrib-bot added a commit to cake-contrib-bot/website that referenced this issue Dec 24, 2024
@cake-contrib-bot
(cake-buildGH-3127) Delete Cake.DotNetTool.Module.yml
a2a2d74
@cake-contrib-bot cake-contrib-bot linked a pull request Dec 24, 2024 that will close this issue
Open
@Jericho
Copy link
Contributor

Jericho commented Dec 24, 2024

@nils-a I guess the yml wasn't deleted in 2021 like we thought!!!?!?!?!?!

@nils-a
Copy link
Member

nils-a commented Dec 25, 2024

Yes. Carefully reading #1743, we specifically decided against deleting so we have things documented for older versions, too.

I see two ways forward from here:

  1. we add a new feature in AddinDiscoverer, to have something "Blacklisted" and not delete the corresponding yaml, or
  2. we simply leave the newly generated PR open (as was the old one) but document (a bit better this time) why we left it open. 😬

@Jericho
Copy link
Contributor

Jericho commented Dec 26, 2024

number 2 is simplest. As long as we make it clear that we intend to leave the issue open so that I don't try to close it in a few years!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delete Cake.DotNetTool.Module.yml (DO NOT MERGE) cake-contrib-bot/website
3 participants
@Jericho @nils-a @cake-contrib-bot