Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide task to download icon for embedding into NuGet package #613

Closed
gep13 opened this issue Aug 5, 2020 · 5 comments
Closed

Provide task to download icon for embedding into NuGet package #613

gep13 opened this issue Aug 5, 2020 · 5 comments
Assignees

Comments

@gep13
Copy link
Member

gep13 commented Aug 5, 2020

This will be especially useful for places like the Cake-Contrib organisation, that creates lots of packages that are published to NuGet.org. Rather than replicating the icon into each repository, or using a technique like git submodules to include the icon, provide a task which will fetch the icon to a defined location, which can then be used as part of the build.

This task should:

  • not run be default, it should be opted into
  • accept a parameter for the URL of where to download the icon from (default to Cake-Contrib icon)
  • accept a parameter for the name of the saved file
  • accept a parameter for where the icon should be saved (default to known location best for Cake-Contrib projects)
  • provide another task to delete the icon (this should be a top level task with no dependents)
@gep13 gep13 added the Feature label Aug 5, 2020
@gep13 gep13 added this to the 2.0.0 milestone Aug 5, 2020
@gep13 gep13 self-assigned this Aug 5, 2020
@gep13
Copy link
Member Author

gep13 commented Aug 5, 2020

@AdmiringWorm what are your thoughts on this one?

@Jericho
Copy link
Member

Jericho commented Aug 5, 2020

This task should also validate that csproj/nuspec is properly referencing this icon.

@gep13
Copy link
Member Author

gep13 commented Aug 5, 2020

Ooo, that is an interesting idea!

@AdmiringWorm
Copy link
Member

As long as it is kept as on opt-in, then I don't have any issues regarding this feature.

@gep13
Copy link
Member Author

gep13 commented Aug 26, 2020

I am going to close this issue out, in favour of what is being discussed here:

cake-contrib/Home#11

This seems like a better approach going forward.

@gep13 gep13 closed this as completed Aug 26, 2020
@gep13 gep13 removed the Feature label Aug 26, 2020
@gep13 gep13 removed this from the 2.0.0 milestone Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants