Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide alternative tool paths #8

Closed
fwinkelbauer opened this issue Apr 20, 2017 · 4 comments
Closed

Provide alternative tool paths #8

fwinkelbauer opened this issue Apr 20, 2017 · 4 comments
Milestone

Comments

@fwinkelbauer
Copy link
Contributor

The cake documentation for tools state that Cake can ask a Tool for "additional, alternative paths". Looking at the interface signature of the Tool class I found this method:

protected virtual IEnumerable<FilePath> GetAlternativeToolPaths(TSettings settings);

I was wondering if:

  • this is the method mentioned in the above documentation
  • it would be a good idea to add e.g. the default location of metrics.exe for Visual Studio 2015. This would remove the necessity of manually registering the tool (as shown here)

Another question I have is:

  • Why does the above GetAlternativeToolPaths offer TSettings as a parameter? Should TSettings contain a property which states the tool version (e.g. metrics VS 2015)?

@gep13 May I ask for your insight/input?

@gep13
Copy link
Member

gep13 commented Apr 20, 2017

@fwinkelbauer yes, that is exactly correct.

You can see an example of this here:

https://github.com/cake-contrib/Cake.CMake/blob/develop/src/Cake.CMake/CMakeRunner.cs#L81

P.S. As a side note...

Did you see these:
cake-contrib/Home#3
cake-contrib/Home#2

Hoping to get you added to both as well.

@fwinkelbauer
Copy link
Contributor Author

@gep13 thanks! I'll experiment with that method

Yes, I have seen these issues. I feel kinda weird admitting that I do not have a twitter or a slack account. Do you feel like joing slack is the best way to go forward with the overall cake-contrib group (e.g. concerning future changes or maintenance)?

@gep13
Copy link
Member

gep13 commented Apr 20, 2017

@fwinkelbauer the Cake Contrib Slack Team is intended as a central place where addin maintainers can discuss and ask questions. In addition, the Slack Team integrations for things like GitHub and AppVeyor, make it very easy to monitor what is going on with other projects within the Cake Contrib Organisation. We use Slack entensively within the Core Cake Team, and I believe it will be a valuable resource for the Cake Contrib Team as well.

fwinkelbauer added a commit that referenced this issue Apr 21, 2017
This is a first draft to provide alternative tool paths for metrics.exe
based on a ToolVersion parameter. Currently VS2013 and VS2015 are
supported
@fwinkelbauer
Copy link
Contributor Author

fwinkelbauer commented Apr 21, 2017

I have just pushed a first implementation of the alternative tool paths feature. What I still have to do:

  • Understand how I can write a test for this using the Cake addin lib
  • Check if there are other metrics.exe versions out there besides VS2013 and VS2015
  • Update code snippet documentation (code comments, README, ...)
  • Make sure that GetAlternativeToolPaths really provides the highest possible tool using the VsMetricsToolVersion.Default setting. @gep13 can you give some insight on this? I am assuming that Cake would take the first available path it would find. So if the returned collection is sorted descending I should be fine, right?

@gep13 I have sent you an e-mail using your blog's contact form regarding the Slack invitation

fwinkelbauer added a commit that referenced this issue Apr 21, 2017
@fwinkelbauer fwinkelbauer added this to the 0.2.0 milestone Apr 25, 2017
fwinkelbauer added a commit that referenced this issue Apr 28, 2017
This is a first draft to provide alternative tool paths for metrics.exe
based on a ToolVersion parameter. Currently VS2013 and VS2015 are
supported
fwinkelbauer added a commit that referenced this issue Apr 28, 2017
fwinkelbauer added a commit that referenced this issue May 2, 2017
cake-contrib-bot pushed a commit that referenced this issue May 2, 2017
Merge pull request #9 from cake-contrib/alternativeToolPaths

(GH-8) Provide alternative tool paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants