Inconsistent seed grouping (monero)

[nahuhh]

Describe the bug

1. When wallet restore doesnt match, the seed isn't grouped.
2. Opening a wallet in the group caused it to be "ungrouped". One if the wallets has no restore height listed on keys page

dirty fix: if primary addr match, group them.

[OmarHatem28]

hi @nahuhh thanks for opening this issue, currently Monero shouldn't be grouped anyway, only Bip39 wallets should be grouped so even Bitcoin and Litecoin wallets which are created as Electrum seeds should not be grouped

this feature will work best for newly created wallets,
for restored wallets, it shouldn't group them unless the addresses match as we do not share seeds with other wallets

we will add support for Monero as well when we add support for BIP39 to monero seeds as well soon

we will look into why it grouped it in the first place tho, but can you give me more info on which wallets it grouped it with? i.e did it group it with a Monero wallet, or with some other wallet types

[nahuhh]

i have the same monero wallet added multiple times with diff restore heights.

grouped with monero wallets

[tuxpizza]

Just to be sure, opening all the affected wallets reset their state and ungrouped them? So now your wallet screen has a *correct state for wallet groups?

[nahuhh]

Just to be sure, opening all the affected wallets reset their state and ungrouped them?

yes

So now your wallet screen has a screen state for wallet groups?

not sure i understand the question.
now it looks like there are no groups

[tuxpizza]

Meant "Correct state" :P
If you aren't expecting any wallet groups to show up and have no wallets with the same seed, then having no wallet groups is the correct result.

[nahuhh]

Meant "Correct state" :P
If you aren't expecting any wallet groups to show up and have no wallets with the same seed, then having no wallet groups is the correct result.

I have multiple wallets with the same seed (diff restore height)

Lets say
seed 1: Nahuhhold nahuhhnew nahuhharchive

seed 2: nahuhh2 nahuhh2old nahuhhtwo

it was grouping nahuhhold nahuhhnew but not nahuhharchive
and was not grouping seed2 at all.

after opening the seed1 wallets, the group disappeared.

if xmr should not be grouping, then the bug was that it grouped them (then ungrouped them).

if same-seed for xmr should be grouping, the bug is that its inconsistently grouping some same-seed Xmr wallets, but not others.

[tuxpizza]

Ok yeah this feature doesn't work for Monero yet so there isn't supposed to be any wallet groups with Monero.

Will have to investigate the upgrade glitch causing incorrect wallet groups further