Skip to content

4.x major: Remove deprecations, fix up MultiChecker. #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: 3.x
Choose a base branch
from
Open

4.x major: Remove deprecations, fix up MultiChecker. #748

wants to merge 12 commits into from

Conversation

@dereuromark
Copy link
Member

@dereuromark dereuromark commented Nov 6, 2025

Prepare #716

@dereuromark dereuromark closed this Nov 6, 2025
@dereuromark dereuromark reopened this Nov 6, 2025
@dereuromark
Copy link
Member Author

dereuromark commented Nov 6, 2025

For some reason 4.x is now protected already, even though just created.
I have the ready branch at "4.x-squashed", maybe someone with access can just force push into 4.x?

@dereuromark dereuromark requested a review from ADmad November 6, 2025 06:04
@ADmad
Copy link
Member

ADmad commented Nov 6, 2025

For some reason 4.x is now protected already, even though just created.

The protection rule is set for *.x, that's way. I have temporarily changed it to 3.x, so you should be able to force push to 4.x now.

@dereuromark dereuromark marked this pull request as ready for review November 6, 2025 14:27
ADmad
ADmad reviewed Nov 6, 2025
View reviewed changes
dereuromark and others added 3 commits November 6, 2025 18:27
@dereuromark @ADmad
Update src/Authenticator/EnvironmentAuthenticator.php
f6dab98 
Co-authored-by: ADmad <admad.coder@gmail.com>
@dereuromark @ADmad
Update src/Authenticator/JwtAuthenticator.php
6480113 
Co-authored-by: ADmad <admad.coder@gmail.com>
@dereuromark @ADmad
Update src/Authenticator/TokenAuthenticator.php
d5ee52b 
Co-authored-by: ADmad <admad.coder@gmail.com>
@dereuromark
Copy link
Member Author

dereuromark commented Nov 6, 2025

Auth code looks pretty clean and cake-user-friendly now, doesnt it?

@dereuromark dereuromark changed the title Remove deprecations, fix up MultiChecker. 4.x major: Remove deprecations, fix up MultiChecker. Nov 7, 2025
@dereuromark dereuromark added this to the 4.x milestone Nov 20, 2025
@dereuromark
Copy link
Member Author

dereuromark commented Nov 29, 2025

@ADmad How do we merge our regression fix into this?
Do we want to keep the "cleaner" constructor of 4.x? Or do we move to the lazy defaulting?

@ADmad
Copy link
Member

ADmad commented Nov 29, 2025 •
edited
Loading

Doing it in getIdentifier() does have the benefit that the objects chain gets initialized only when needed.

@dereuromark
Merge branch '3.x' into 4.x
2ba7ed9 
- Use lazy identifier initialization in getIdentifier() (3.x approach)
- Add AuthenticationPlugin as main plugin class, Plugin as deprecated alias
- Add redirect validation feature from 3.x
- Update all authenticators to use getIdentifier() instead of direct property access
ADmad
ADmad reviewed Nov 29, 2025
View reviewed changes
dereuromark and others added 2 commits November 29, 2025 20:52
@dereuromark @ADmad
Apply suggestions from code review
5105cdd 
Co-authored-by: ADmad <admad.coder@gmail.com>
@dereuromark
Fix syntax.
2ac8fd5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ADmad ADmad ADmad left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.x

Development

Successfully merging this pull request may close these issues.

3 participants

@dereuromark @ADmad