Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev authorized keys are additive #115

Open
daaray opened this issue Aug 7, 2014 · 5 comments
Open

dev authorized keys are additive #115

daaray opened this issue Aug 7, 2014 · 5 comments
Assignees

Comments

@daaray
Copy link
Contributor

daaray commented Aug 7, 2014

If I change a developer's public key, it adds it to their authorized keys. I would expect a 1:1 mapping of keys in the conf to those on the server.

As it stands, if I change a key due to it being compromised, a deploy would leave the compromised keys on the server.

@mlavin
Copy link
Contributor

mlavin commented Aug 7, 2014

No obvious solution to this problem. There isn't a Salt state to assert the entire contents of the authorize keys. Only that single keys are present or absent. http://docs.saltstack.com/en/latest/ref/states/all/salt.states.ssh_auth.html#module-salt.states.ssh_auth

Similar problems for other removed states/pillars. Just because you remove the worker state doesn't mean the Supervisor config and the currently running service will be removed. You have to go back and do a one off clean up.

@daaray
Copy link
Contributor Author

daaray commented Aug 7, 2014

Fair enough. That one off would look something like (or just ssh to the machine and ✂️ it).

fab [env] salt:'ssh.rm_auth_key [user] [key]

@daaray daaray closed this as completed Aug 7, 2014
@mlavin
Copy link
Contributor

mlavin commented Aug 7, 2014

Let's not close this. It is a problem. As you said it just needs some docs or a fab shortcut to help with it.

@mlavin mlavin reopened this Aug 7, 2014
@daaray daaray self-assigned this Aug 7, 2014
@dpoirier
Copy link
Contributor

Maybe when we want to remove a user from the system, instead of removing the user from our list, we could add a "state: removed" or something like that, then look for it when processing the user entries?

@vkurup
Copy link
Contributor

vkurup commented Aug 28, 2015

Margarita portion tracked in caktus/margarita#66. We would then need some docs/examples over here on how to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants