Pip upgrade issue

[daaray]

On a newly provisioned 12.04 box with python 2.7, with or without this change that pins setuptools (5ffd6a7), the following error occurs on the initial fab vagrant deploy:

2015-01-08 00:47:25,527 [salt.loaded.int.module.cmdmod][ERROR   ] Command '/usr/bin/pip freeze' failed with return code: 2
2015-01-08 00:47:25,528 [salt.loaded.int.module.cmdmod][ERROR   ] stderr: Exception:
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/pip/basecommand.py", line 126, in main
    self.run(options, args)
  File "/usr/lib/python2.7/dist-packages/pip/commands/freeze.py", line 68, in run
    req = pip.FrozenRequirement.from_dist(dist, dependency_links, find_tags=find_tags)
  File "/usr/lib/python2.7/dist-packages/pip/__init__.py", line 156, in from_dist
    assert len(specs) == 1 and specs[0][0] == '=='AssertionError

ssh'ing into the box reveals:

daaray@precise32:/var/log/salt$ sudo pip --version
pip 1.0 from /usr/local/lib/python2.7/dist-packages (python 2.7)

I can work through this by manually upgrading pip at the command line and the do another deploy

daaray@precise32:/var/log/salt$ sudo pip install pip -U
...
daaray@precise32:/var/log/salt$ sudo pip --version
pip 6.0.6 from /usr/local/lib/python2.7/dist-packages (python 2.7)

I am uncertain as to why it is not upgrading itself without failing.

[mlavin]

Digging through the Salt code the issue might be here: https://github.com/saltstack/salt/blob/v2014.7.0/salt/states/pip_state.py#L486
The states should currently upgrade setuptools then upgrade pip. Before calling pip install pip -U, it will run pip freeze. So we should have the most recent setuptools and pip 1.0 which is a potential source of conflict.

We should rethink how we bootstrap this system pip version. ensurepip is broken on Ubuntu/Debian (See https://bugs.launchpad.net/ubuntu/+source/python3.4/+bug/1290847). One possible solution would be:

• Don't install python-pip from apt
• Remove setuptools upgrade
• Check if pip is installed
  • If not installed, download and run get-pip.py via https://bootstrap.pypa.io/get-pip.py
  • If installed, have it upgrade itself

get-pip.py doesn't require setuptools to be installed before hand as of 1.5.1. I'm sure that future versions of pip will find some new and inventive way to break this workflow as well but it's worth a shot.

[vkurup]

I'm not certain, but I think this can be closed now. I had seen this error in the past, but not on recent projects.

[yesimon]

Although I don't use margarita - I found this issue while googling. The default version of pip packaged on ubuntu 15.04 is still 1.5.6. https://launchpad.net/ubuntu/+source/python-pip. I still had to do something like this to get the a working pip.