Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should vagrant use dev or production requirements #73

Open
vkurup opened this issue Sep 4, 2015 · 7 comments
Open

Should vagrant use dev or production requirements #73

vkurup opened this issue Sep 4, 2015 · 7 comments

Comments

@vkurup
Copy link
Contributor

vkurup commented Sep 4, 2015

I tried to set up celery today and when testing on vagrant, celery complained that the memcached module was not set up, which is because we are using dev.txt instead of production.txt:

https://github.com/caktus/margarita/blob/develop/project/venv.sls#L22-L26

Given that we use deploy.py settings for vagant, we should probably switch that right?

@mlavin
Copy link
Contributor

mlavin commented Sep 4, 2015

I don't think we've ever agreed on this. Some people want to use Vagrant as a local dev environment and others use it to test the deployment (staging/production). I can't be both.

@dpoirier
Copy link
Contributor

Maybe we need two Vagrant-based environments, one for local development and one for testing deploys? Maybe env "local" for the first and env "vagrant" for the second?

@mlavin
Copy link
Contributor

mlavin commented Feb 9, 2016

There is a related problem in project/repo.sls in that it assumes that the Vagrant deployment is run from the project repo. We've had more projects where this isn't the case. I don't think this should use the mounted file system if you are trying to replicate a prod-like environment.

@dpoirier
Copy link
Contributor

What's the use case for not running the Vagrant deploy from the project repo? I'm having trouble imagining how that would work.

@mlavin
Copy link
Contributor

mlavin commented Feb 10, 2016

For cases like Ona, ServiceInfo, or in my case Tracpro where the deployment is managed in a repo separate from the project source.

@dpoirier
Copy link
Contributor

Oh I see. I think I'd still refer to our repo for that as our project repo, which led to my confusion.

@mlavin
Copy link
Contributor

mlavin commented Feb 10, 2016

Yes I mean specifically that https://github.com/caktus/margarita/blob/develop/project/repo.sls#L26 assumes that the project source tree is mounted in the /vagrant/ which is not always the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants