Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance EnrollmentFlow model with field to indicate it is a pathway that can only be done in-person #2287

Open
3 tasks
Tracked by #2261
angela-tran opened this issue Aug 6, 2024 · 3 comments · May be fixed by #2383
Open
3 tasks
Tracked by #2261
Assignees
Labels
back-end Django views, sessions, middleware, models, migrations etc.

Comments

@angela-tran
Copy link
Member

angela-tran commented Aug 6, 2024

We need a way to represent that a flow is digital-only, in-person only, or supports both.

Acceptance Criteria

  • A flow that is digital-only shows up only on the digital side
  • A flow that is in-person only shows up only on the in-person side
  • A flow that supports both shows up on both sides
@angela-tran
Copy link
Member Author

angela-tran commented Aug 6, 2024

ignore this comment 😅

Done shaping, need to ask for feedback

My thought on this is that this modeling reflects the use case we have in mind. We can refactor this field into something else if the use case changes.

@thekaveman
Copy link
Member

thekaveman commented Sep 11, 2024

Let's align the field naming here with what we choose for the property name in #2245

@indexing suggests supported_methods for the name of the field/property.

Devs suggest possible values of digital or in_person. Note this should be a multi-select: one or both values can be chosen.

@thekaveman thekaveman added the back-end Django views, sessions, middleware, models, migrations etc. label Sep 12, 2024
@thekaveman thekaveman assigned thekaveman and unassigned thekaveman Sep 17, 2024
@thekaveman
Copy link
Member

thekaveman commented Sep 17, 2024

This can reuse some of the helpers introduced in #2367

E.g. benefits.core.models.EnrollmentMethods is a class with two properties for the strings digital and in_person.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end Django views, sessions, middleware, models, migrations etc.
Projects
Status: In progress
3 participants