Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin: Decide what to do with "Change password" page #2384

Open
angela-tran opened this issue Sep 19, 2024 · 2 comments
Open

Admin: Decide what to do with "Change password" page #2384

angela-tran opened this issue Sep 19, 2024 · 2 comments
Assignees
Labels
product Issue captures work for the product team

Comments

@angela-tran
Copy link
Member

angela-tran commented Sep 19, 2024

When logged in as a native Django user account, you'll see a "Change password" link in the usertools section.

image

That link takes us to a page that we have not overridden / that doesn't use our extrastyles, so it uses all the default Django styles.

image

Originally posted by @angela-tran in #2371 (comment)

We should decide if we're keeping this page in and if we should style it like the rest of the agency-facing pages.

@angela-tran angela-tran added the product Issue captures work for the product team label Sep 19, 2024
@machikoyasuda machikoyasuda changed the title Decide what to do with "Change password" page Admin: Decide what to do with "Change password" page Sep 19, 2024
@angela-tran angela-tran added this to the Admin tool: agency users milestone Sep 20, 2024
@angela-tran
Copy link
Member Author

angela-tran commented Oct 3, 2024

I wanted to see what this page would look like if I made some bare minimum changes, like

  • import our admin styles and Bootstrap into the page
  • remove sections like the breadcrumbs and sidebar so it matches our other pages

This is the result:

Before After
image Image

I'll open a draft PR that shows the few code changes that were needed to get this.

There's a template that's shown after the user successfully changes their password (registration/password_change_done.html), so I'd need to do the same thing for it:

Image

@angela-tran
Copy link
Member Author

angela-tran commented Oct 3, 2024

Here's what password_change_done.html looks like with the same type of minimal code changes:

Image

(Caveat: I did add the "Back to dashboard" button)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product Issue captures work for the product team
Projects
Status: Todo
Development

No branches or pull requests

2 participants