Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: RT Speedmaps URLs can change when agencies are added/removed/re-ordered, breaking reports site links #754

Open
1 of 5 tasks
atvaccaro opened this issue May 17, 2023 · 1 comment
Assignees
Labels
admin Administrative work bug Something isn't working portfolio work Work related to the analytics portfolio

Comments

@atvaccaro
Copy link
Contributor

Where did the bug occur?
Select from the below, and be sure to affix the appropriate label to this issue (e.g. dataset, jupyterhub, metabase, analytics.calitp.org)

  • Data (the warehouse)
  • JupyterHub
  • Metabase
  • analytics.calitp.org
  • Other (add detail)

Describe the bug
Currently, the reports data generation code creates a mapping between agencies and their URLs on the speedmaps analysis site. However, this mapping can become stale if new agencies are added to the analysis site and URLs change. This is because the URLs include an enumerated index integer, which can change if the order of sections change.

To Reproduce
Steps to reproduce the behavior:
Deploy the RT speedmaps portfolio site after adding additional agencies, and notice that the reports site speedmap URLs remain unchanged while the actual analysis site has changed.

Expected behavior
We need to make the URLs more deterministic, or fetch the speedmaps URLs dynamically in the reports code.

Additional context
https://cal-itp.slack.com/archives/C034EJ0KX8S/p1682010289859259

@atvaccaro atvaccaro added bug Something isn't working admin Administrative work labels May 17, 2023
@atvaccaro atvaccaro self-assigned this May 17, 2023
@atvaccaro atvaccaro changed the title Bug: : [description] Bug: RT Speedmaps URLs can change when agencies are added/removed/re-ordered, breaking reports site links May 17, 2023
@tiffanychu90 tiffanychu90 added the portfolio work Work related to the analytics portfolio label Nov 15, 2023
@KatrinaMKaiser
Copy link
Member

@edasmalchi / @vevetron - can this issue be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin Administrative work bug Something isn't working portfolio work Work related to the analytics portfolio
Projects
None yet
Development

No branches or pull requests

3 participants