From dcc871a269d6fd2b3af8279046ee0ad728765982 Mon Sep 17 00:00:00 2001 From: Charles Costanzo Date: Fri, 21 Feb 2025 12:26:14 -0500 Subject: [PATCH] utilize unnested ntd_agency_info_key as ntd_id value for dim_organization rows prior to cutover date --- .../mart/transit_database/dim_organizations.sql | 11 +---------- .../stg_transit_database__organizations.sql | 1 + 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/warehouse/models/mart/transit_database/dim_organizations.sql b/warehouse/models/mart/transit_database/dim_organizations.sql index 9ced24b464..cd45d0ae1e 100644 --- a/warehouse/models/mart/transit_database/dim_organizations.sql +++ b/warehouse/models/mart/transit_database/dim_organizations.sql @@ -4,11 +4,6 @@ WITH dim AS ( SELECT * FROM {{ ref('int_transit_database__organizations_dim') }} ), --- This is deprecated, what replaced the source of truth for ntd_id < '2023-05-23' that was previously found in ntd_to_org.ntd_id ?? --- ntd_agency_to_organization AS ( --- SELECT * FROM {{ ref('_deprecated__ntd_agency_to_organization') }} --- ), - dim_organizations AS ( SELECT key, @@ -31,10 +26,8 @@ dim_organizations AS ( -- use same May 23, 2023 cutover date as `assessment_status` --> `public_currently_operating` in downstream models for consistency CASE WHEN _valid_from >= '2023-05-23' THEN raw_ntd_id - ELSE ntd_to_org.ntd_id + ELSE ntd_agency_info_key END AS ntd_id, - - -- is this not related to ntd_to_org.ntd_id (ntd_id < '2023-05-23') ?? ntd_id_2022, public_currently_operating, public_currently_operating_fixed_route, @@ -43,8 +36,6 @@ dim_organizations AS ( _valid_to FROM dim - LEFT JOIN ntd_agency_to_organization ntd_to_org - ON source_record_id = ntd_to_org.organization_record_id ) SELECT * FROM dim_organizations diff --git a/warehouse/models/staging/transit_database/stg_transit_database__organizations.sql b/warehouse/models/staging/transit_database/stg_transit_database__organizations.sql index 7cd883f8fc..8e01c2ab14 100644 --- a/warehouse/models/staging/transit_database/stg_transit_database__organizations.sql +++ b/warehouse/models/staging/transit_database/stg_transit_database__organizations.sql @@ -46,6 +46,7 @@ stg_transit_database__organizations AS ( public_currently_operating_fixed_route = "Yes" AS public_currently_operating_fixed_route, FROM once_daily_organizations LEFT JOIN UNNEST(once_daily_organizations.ntd_id) as unnested_ntd_records + ) SELECT * FROM stg_transit_database__organizations