chore(devcontainer): clean up build, settings, pre-commit install

- copy git directory for version metadata
- move pre-commit install to postAttach
- clean up deprecated settings

Author: thekaveman

.devcontainer/Dockerfile

@@ -5,11 +5,5 @@ COPY docs/requirements.txt docs/requirements.txt
 RUN pip install --no-cache-dir -r docs/requirements.txt
 
 # install devcontainer requirements
+COPY .git .git
 RUN pip install -e .[dev,test]
-
-# install pre-commit environments in throwaway Git repository
-# https://stackoverflow.com/a/68758943
-COPY .pre-commit-config.yaml .
-RUN git init . && \
-    pre-commit install-hooks && \
-    rm -rf .git

.devcontainer/devcontainer.json

@@ -5,6 +5,7 @@
   "service": "dev",
   "runServices": ["dev", "docs"],
   "workspaceFolder": "/home/calitp/app",
+  "postAttachCommand": ["/bin/bash", ".devcontainer/postAttach.sh"],
   "postStartCommand": ["/bin/bash", "bin/init.sh"],
   "customizations": {
     // Set *default* container specific settings.json values on container create.

.devcontainer/postAttach.sh

@@ -0,0 +1,4 @@
+#!/usr/bin/env bash
+set -eu
+
+pre-commit install --install-hooks

.vscode/settings.json

@@ -9,10 +9,7 @@
   "[python]": {
     "editor.defaultFormatter": "ms-python.black-formatter"
   },
-  "python.formatting.provider": "none",
   "python.languageServer": "Pylance",
-  "python.linting.enabled": true,
-  "python.linting.flake8Enabled": true,
   "python.testing.pytestArgs": ["tests"],
   "python.testing.pytestEnabled": true,
   "python.testing.unittestEnabled": false,