Skip to content

Error when using it in JSDom in case document is undefined #130

Open
@leifmarcus

Description

@leifmarcus

Describe the bug
When using the construct-style-sheet for instance in JSDom, then in some cases, document seems to be undefined. There was an if condition introduced with a fix:

if (!document) {

This will throw an error when document is undefined: Error: Uncaught [ReferenceError: document is not defined]

To Reproduce
Steps to reproduce the behavior: Is not as easy to provide a reproduction, but the bug is clear, I guess.

Expected behavior
The error should not be thrown in non-dom-like environments.
In order to solve the problem, the if condition needs to be

// this will not throw an error when document is not defined.
if (typeof document === 'undefined') {

Additional context
So far, this problem was detected in JSDom environment when running custom components in Vitest.

Activity

denyo

denyo commented on Sep 26, 2024

@denyo
Contributor

There is this PR already: #128

felixmagnus

felixmagnus commented on Oct 18, 2024

@felixmagnus

Any update on this? Would be great if the PR could be merged 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @leifmarcus@denyo@felixmagnus

        Issue actions

          Error when using it in JSDom in case `document` is undefined · Issue #130 · calebdwilliams/construct-style-sheets