Skip to content

Commit e995eb7

Browse files
committed
Show notice when --verbose and --concurrency > 1
1 parent 5ec9381 commit e995eb7

File tree

1 file changed

+16
-11
lines changed

1 file changed

+16
-11
lines changed

packages/ferric/src/build.ts

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,10 @@ const verboseOption = new Option(
134134
"Print more output from underlying compiler & tools",
135135
).default(process.env.CI ? true : false, `false in general and true on CI`);
136136

137+
function logNotice(message: string, ...params: string[]) {
138+
console.log(`${chalk.yellow("ℹ︎")} ${message}`, ...params);
139+
}
140+
137141
export const buildCommand = new Command("build")
138142
.description("Build Rust Node-API module")
139143
.addOption(targetOption)
@@ -173,8 +177,12 @@ export const buildCommand = new Command("build")
173177
},
174178
);
175179
}
176-
// Force a limit of 1 concurrent task to avoid interleaving output
177-
const limit = pLimit(verbose ? 1 : concurrency);
180+
if (verbose && concurrency > 1) {
181+
logNotice(
182+
`Consider passing ${chalk.blue("--concurrency")} 1 when running in verbose mode`,
183+
);
184+
}
185+
const limit = pLimit(concurrency);
178186
const targets = new Set([...targetArg]);
179187
if (apple) {
180188
for (const target of APPLE_TARGETS) {
@@ -200,15 +208,12 @@ export const buildCommand = new Command("build")
200208
targets.add("aarch64-apple-ios-sim");
201209
}
202210
}
203-
console.error(
204-
chalk.yellowBright("ℹ"),
205-
chalk.dim(
206-
`Using default targets, pass ${chalk.italic(
207-
"--android",
208-
)}, ${chalk.italic("--apple")} or individual ${chalk.italic(
209-
"--target",
210-
)} options, to avoid this.`,
211-
),
211+
logNotice(
212+
`Using default targets, pass ${chalk.blue(
213+
"--android",
214+
)}, ${chalk.blue("--apple")} or individual ${chalk.blue(
215+
"--target",
216+
)} options, choose exactly what to target`,
212217
);
213218
}
214219
ensureCargo();

0 commit comments

Comments
 (0)