Skip to content

Commit 9946592

Browse files
authored
chore: fix golangci.yml issues (timeout, format) (maistra#23)
Found that the `deadline: 10m` was incorrect, the correct way to set the timeout is `timeout: 10m` (per https://golangci-lint.run/usage/configuration/). I think this should address the issue that popped up in running the github actions. While fixing this, also found that the way we set the format was incorrect, `formats` requires an array, we were passing a string. Also included changes from running `make` post bumping down controller-gen versions while bumping down go.mod version to 1.21.
1 parent dfef2b0 commit 9946592

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

.golangci.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,10 +95,11 @@ linters:
9595
- gomnd
9696

9797
run:
98-
deadline: 10m
98+
timeout: 10m
9999

100100
output:
101-
formats: colored-line-number
101+
formats:
102+
- format: colored-line-number
102103
print-issued-lines: true
103104
print-linter-name: true
104105

config/crd/external/authorino.kuadrant.io_authconfigs.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@ apiVersion: apiextensions.k8s.io/v1
33
kind: CustomResourceDefinition
44
metadata:
55
annotations:
6-
controller-gen.kubebuilder.io/version: v0.13.0
6+
controller-gen.kubebuilder.io/version: v0.9.2
7+
creationTimestamp: null
78
name: authconfigs.authorino.kuadrant.io
89
spec:
910
group: authorino.kuadrant.io

config/rbac/role.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
apiVersion: rbac.authorization.k8s.io/v1
33
kind: ClusterRole
44
metadata:
5+
creationTimestamp: null
56
name: manager-role
67
rules:
78
- apiGroups:

0 commit comments

Comments
 (0)